Re: [Cdk-jchempaint] highlighting, blurring, etc

[Egon W. <ego...@gm...>]

On Thu, Jan 9, 2014 at 2:55 PM, John May <jo...@eb...> wrote:
> No, were not using the CDK-JChemPaint as it does not have the editor (i.e.
> JChemPaintPanel).

Such panels are toolkit (SWT, Swing, ...) specific... that's why.

> The JChemPaint-HotFix is based on
> https://github.com/jchempaint/jchempaint patched up to 1.5.4. The 1.5.x.
> gives us stereochemistry depiction and export to/from SMILES/InChI and
> Molfile. I've also stripped out the ability to run as an applet (replaced
> the nestedvm inchi with the CDK InChIGenerator) and have added OPSIN for
> name-to-structure. There’s still lots more to fix. I don’t have the time to
> maintain this to an official capacity but if people want a good working
> desktop version of JChemPaint - it’s there.

How much copied code is there still in JChemPaint-HotFix? That is, how
much of the fork is still left?

> Does the CDK-JChemPaint contain those IUndoRedoable? If so I’m sure if this
> should be in the main code base.

The idea is to have a toolkit-independent abstraction... I think we
have that... I can check if you like...

> It’s not a very good API and I think it’s
> much easier just to write a custom undoable/edit using the Swing or SWT API.

I am very happy with the code that Arvid worked on...

> Trying to use it in JChemPaint is a pain as the interfaces are merely an
> illusion and in reality it just cast to UndoableEdit (Swing API).

Are you sure SWT doesn't have a separate API?

Egon


-- 
Dr E.L. Willighagen
Postdoctoral Researcher
Department of Bioinformatics - BiGCaT
Maastricht University (http://www.bigcat.unimaas.nl/)
Homepage: http://egonw.github.com/
LinkedIn: http://se.linkedin.com/in/egonw
Blog: http://chem-bla-ics.blogspot.com/
PubList: http://www.citeulike.org/user/egonw/tag/papers
ORCID: 0000-0001-7542-0286