From: John M. <joh...@gm...> - 2013-12-02 14:51:03
|
> That code looks fine - indeed, it is exactly that in AbstractRenderer.setup? Yep - need to think about it more though as looking at the usages some generators are more difficult to refactor. Indeed the SVG is longer - interestingly Batik always renders fonts as paths and it avoids using the text element (example with CDK). I saw on one of your linked posts that one aim was to provide a relatable font size. Although this would be nice I think it’s a lot harder to do that and to make it look good. From the IUPAC graphical representation standards it does mention a minimum font but also that font/bond length and width should be relative. The advantage of using the shapes is the placement calculations can be done in the generator (no graphics context needed) and the charge, radical and hydrogen labels can stay in place. Currently some label placement is done in the renderer and some in the generator which leads to some problems - such as charge labels drifting away (see below). I’ll make the small changes to the draw visitor and make the generator available for people to try. It needs a lot more work before being fully integrated in the CDK as it’s currently about ~1500 lines of messy unit vectors but should provide decent renderings. Cheers, John |