Re: [Cdk-devel] [SPAM] Re: Chemical formula generator in CDK

[Miguel R. C. <mig...@ya...>]

Dear Thomas,

Please go ahead. I try to check if the test are running correctly afterwards.

Kind regards,
 Miquel

--
Miquel Rojas Chertó
http://miquelrojascherto.com
Leiden/Amsterdam Center for Drug Research || Netherlands Metabolomics Centre
m....@la... || mig...@gm...


On Thu, Nov 1, 2012 at 1:50 AM, Tomas Pluskal <pl...@oi...> wrote:
> Hi John,
>
>
> Looks great - will wait for Miguel to give his opinions on the method but on
> the implementation side I can answer a few things.
>
>
> Seem like Miguel has no opinion.. I will proceed with creating a new class
> for this.
>
> It might be worth deprecating the existing class and writing a clean
> implementation. We have this with SSSR, there is an old deprecated version
> and a newer implementation. This will then serve as a) and archive of the
> algorithm and b) won't break any existing code that is using it.
>
>
> I like this idea.
>
> In this case, I could submit the patch also to the 1.4 branch, because the
> old code still remains. Is that correct?
>
> Could you please give me a quick advice, what is the current preferred way
> of submitting patches? Should I create a pull request on github? Or create a
> ticket on sourceforge?
>
> Best regards,
>
> Tomas
>
>
> ===============================================
> Tomáš Pluskal
> G0 Cell Unit, Okinawa Institute of Science and Technology Graduate
> University
> 1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan
> WWW: https://groups.oist.jp/g0
> TEL: +81-98-966-8684
> Fax: +81-98-966-2890
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_sfd2d_oct
> _______________________________________________
> Cdk-devel mailing list
> Cdk...@li...
> https://lists.sourceforge.net/lists/listinfo/cdk-devel
>