Re: [Cdk-jchempaint] jchempaint

[Egon W. <ego...@gm...>]

Ralf,

On Wed, Aug 1, 2012 at 1:54 PM, Egon Willighagen
<ego...@gm...> wrote:
> I am going to try again, but will first checkout the source code...

Please find attached two first initial patches... (no idea if other
will follow... I rather focus on getting the CDK-JChemPaint patch
cleaned up further)...

But, one patch removes a class which is completely unrelated to
rendering/controlling and explains the dependency on the qm module.

The other patch is one you should have a close look at... the
instanceof should be done against the interface, not an particular
interface implementation (so, IBond instead of Bond)... now, for
data/nonotify that went well, because "Bond" was the 'data'
implementation and the NNBond implementation from the 'nonotify'
module, this may have worked... however, the silent 'IBond'
implementation does *not* extend the 'data' implementation... I fixed
two classes, but if you run into more such code...

Egon


-- 
Dr E.L. Willighagen
Postdoctoral Researcher
Department of Bioinformatics - BiGCaT
Maastricht University (http://www.bigcat.unimaas.nl/)
Homepage: http://egonw.github.com/
LinkedIn: http://se.linkedin.com/in/egonw
Blog: http://chem-bla-ics.blogspot.com/
PubList: http://www.citeulike.org/user/egonw/tag/papers