Menu
▾
▴
[Cdk-devel] [ cdk-Patches-3515410 ] New ForceFieldConfigurator Test class provided
|
From: SourceForge.net <no...@so...> - 2012-04-06 09:28:55
|
Patches item #3515410, was opened at 2012-04-06 01:56 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3515410&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: cdk-1.4.x >Group: Needs Revision Status: Open Resolution: None Priority: 5 Private: No Submitted By: Daniel Szisz (danielszisz) Assigned to: Egon Willighagen (egonw) Summary: New ForceFieldConfigurator Test class provided Initial Comment: After a long break a new Test class is added to test and debug the functionalities of the ModelBuilder3D package. This new patch adds a Test class for the ForceFieldConfigurator class. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-04-06 02:28 Message: OK, comments: - please add a copyright header (http://chem-bla-ics.blogspot.com/2009/06/making-patches-attribution-copyright.html) - please add a complementary patch for ForceFieldConfigurator with @TestClass and @TestMethod annotation - better have @Test methods throw an exception than to catch them in the test, and have JUnit handle the stacktrace - there is an empty testConfigureMM2BasedAtom_IAtom_String_boolean() method - if there are bug reports associated with those tests, you can use @cdk.bug #### in the method's JavaDoc Looks like a great patch otherwise! - ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-04-06 02:16 Message: BTW, please use the 'Category' field to indicate if you are writing patches against master or cdk-1.4.x. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-04-06 02:15 Message: Oh, cool! I was already looking at and commenting on the other patch, before this reached my inbox :) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3515410&group_id=20024 |