Re: [Cdk-devel] Request for feedback and code review of CDK branch with new fingerprint api

[Jonathan A. <jon...@gm...>]

Rajarshi Guha <raj...@gm...> wrote: (>)

> Overall, looks good. It's a good idea to move beyond BitSet's and have an
> interface for fingerprints. Use cases in the Javadocs would be useful
> (e.g., IntArrayCountFingerprint needs more documentation ).

Okey, so write more Javadoc for IntArraycountFingerprint. Which other classes
must have more javadoc? (I suppose all of them would benefit from more, but
where is it a must?)

> It would be handy to have high level description of the new classes and
> their relationships. For example it's not clear why IntArrayFingerprint
> implements IBitFingerprint. Javadocs would help here.
>
> So at this point, more Javadocs would be required, and a high level
> description would be useful

"high level description", is that also javadoc or is this something else?

Also, are you happy with the naming? Perhaps IntArrayFingerprint would be
clearer as IntArrayBitFingerprint but at some level things just get too long?
Or do they?

> Also, can you sync up with latest master so that I only see the fp related
> chnages?

Yes, I have done this. It needs to be done from time to time of course...
Feel free to do it yourself when you look at the code and hand it back to me to
solve if it doesn't go automagicly and you run into merge conflicts...

-- 
// Jonathan