[Cdk-devel] [ cdk-Patches-3476964 ] makes datadebug logger instances final static to class

[SourceForge.net <no...@so...>]

Patches item #3476964, was opened at 2012-01-21 04:23
Message generated for change (Comment added) made by rajarshi
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3476964&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: cdk-1.4.x
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: makes datadebug logger instances final static to class

Initial Comment:
This patch is for a problem I found when working on another patch, and makes all logging tools final static. There is, I think, no reason why each instance should in fact have a separate logger instance. For this other patch, this one is crucial, as it allows constructors to call class methods, like setOrder(), causing the logging tool to be needed.

Otherwise, this patch does not fix a current bug.

----------------------------------------------------------------------

>Comment By: Rajarshi Guha (rajarshi)
Date: 2012-01-21 10:41

Message:
Wouldn't a final static field make these classes non-threadable (unless
calls to the logger synchronized?)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3476964&group_id=20024