Menu
▾
▴
[Cdk-devel] [ cdk-Patches-3416156 ] Two small fixes for regressions in cdk-1.4.x
|
From: SourceForge.net <no...@so...> - 2011-10-01 13:29:20
|
Patches item #3416156, was opened at 2011-09-30 14:36 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3416156&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x >Group: Accepted >Status: Closed >Resolution: Accepted Priority: 9 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Two small fixes for regressions in cdk-1.4.x Initial Comment: Fixing these issues: Testcase: testSortAtomContainers_Comparator_Null(org.openscience.cdk.AtomContainerSetTest): Caused an ERROR org/openscience/cdk/tools/manipulator/AtomContainerComparator java.lang.NoClassDefFoundError: org/openscience/cdk/tools/manipulator/AtomContainerComparator at org.openscience.cdk.interfaces.AbstractAtomContainerSetTest.testSortAtomContainers_Comparator_Null(AbstractAtomContainerSetTest.java:54) Testcase: testSortAtomContainers_Comparator_Null(org.openscience.cdk.MoleculeSetTest): Caused an ERROR Only IMolecule's can be stored in an IMoleculeSet java.lang.IllegalArgumentException: Only IMolecule's can be stored in an IMoleculeSet at org.openscience.cdk.MoleculeSet.addAtomContainer(MoleculeSet.java:81) at org.openscience.cdk.interfaces.AbstractAtomContainerSetTest.testSortAtomContainers_Comparator_Null(AbstractAtomContainerSetTest.java:49) One fix adds dependencies to the standard module to fix the first error. The second patch has the unit test create an IMolecule to fix the IllegalArgumentException. For the AtomContainerSetText (and variants) it still is an IAtomContainer too, so those tests still work fine too. ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2011-10-01 09:29 Message: Applied and pushed ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2011-10-01 02:21 Message: Oops. Attached now. ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2011-09-30 18:01 Message: no patch attached ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3416156&group_id=20024 |