[Cdk-devel] [ cdk-Patches-3408000 ] Fix for the SMARTSQueryTool

[SourceForge.net <no...@so...>]

Patches item #3408000, was opened at 2011-09-12 12:08
Message generated for change (Comment added) made by jonalv
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3408000&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: master
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: gilleain maclean torrance (gilleain)
Assigned to: Jonathan Alvarsson (jonalv)
Summary: Fix for the SMARTSQueryTool

Initial Comment:
The SMARTSParser throws a CDK exception if there is a Parse Exception when parsing a smarts query as a string. The SQT needs to handle this somehow, as the current code doesn't compile (in Eclipse, anyway).

The fix catches CDKExceptions in the SQT constructor, and then throws an IllegalArgumentException, as the whole thing should fail at this point.

----------------------------------------------------------------------

>Comment By: Jonathan Alvarsson (jonalv)
Date: 2011-09-12 12:25

Message:
Looks fine to me. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3408000&group_id=20024