[Cdk-devel] [ cdk-Patches-3396792 ] Thread safetying of org.openscience.cdk.tools.periodictable.

[SourceForge.net <no...@so...>]

Patches item #3396792, was opened at 2011-08-23 11:24
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3396792&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: cdk-1.4.x
Group: Needs Review
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Thread safetying of org.openscience.cdk.tools.periodictable.

Initial Comment:
* Made the static instances volatile so all threads needs to read their state before accessing them
* Made the initialize method synchronized so threads have to wait for the first method to finish inialisation before attempting and finding it already initialized.

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2011-08-23 11:41

Message:
Looks good to me. As this is hard to test, the lack of a unit test is
acceptable.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3396792&group_id=20024