From: SourceForge.net <no...@so...> - 2011-07-20 08:07:39
|
Patches item #3370547, was opened at 2011-07-18 21:02 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3370547&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) >Assigned to: Rajarshi Guha (rajarshi) Summary: Patch that moves ArrowElement from CDK-JCP to renderbasic Initial Comment: Fixing rendering of reaction schemes. The latter is in renderextra, and the arrow element is just an underlying drawing element. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2011-07-20 10:07 Message: The main purpose of renderbasic / renderX is to be able to remove large dependencies, such as the IsotopeFactory, or all ChemModel level classes... Rajarshi, could you please have a brief look at it too? Then it had two reviews, and it's good to go. ---------------------------------------------------------------------- Comment By: gilleain maclean torrance (gilleain) Date: 2011-07-19 11:30 Message: Yes, this looks fine. It's not much 'extra' to have some more Rendering Element classes, so I don't see why it shouldn't be in renderer basic. Of course, the question arises : couldn't arrows be drawn with line elements? :) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3370547&group_id=20024 |