[Cdk-devel] [ cdk-Patches-3313187 ] suggested fix for bug 3310138

[SourceForge.net <no...@so...>]

Patches item #3313187, was opened at 2011-06-07 16:17
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3313187&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: master
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jonathan Alvarsson (jonalv)
Assigned to: Nobody/Anonymous (nobody)
Summary: suggested fix for bug 3310138

Initial Comment:
The Tanimoto calcualtion for raw fingerprints was broken. This is an implementation of the continous tanimoto score used in DOI: 10.1021/ci800326z

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2011-06-07 17:19

Message:
A quick comment:

1. (minor) please use separate commits for separate fixes, allowing you to
give more detail, e.g. on to what was wrong with the @TestMethod
2. please use {@cdk.cite} in the method JavaDoc rather than just listing
the DOI. See for example the CMLReader class

As to the change of algorithm, the original author should comment on that.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3313187&group_id=20024