From: SourceForge.net <no...@so...> - 2010-12-24 13:50:19
|
Patches item #3029445, was opened at 2010-07-14 12:50 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3029445&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x Group: Accepted Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: MDLWriter should report details on the IO setting(s) Initial Comment: So that from the class JavaDoc it is clear how the output could be customized. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-12-24 14:50 Message: In short, it would be like: $ git checkout -b patchSignoff cdk-1.4.x $ git am -3 --ignore-whitespace 0001-Added-description-of-IO-settings-to-the-writers-Java.patch $ git commit --amend --signoff $ git format-patch -1 And then attach the newly created patch to this report. Make sure to set your email and name correctly, as described here: http://help.github.com/git-email-settings/ ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-12-24 14:48 Message: Sulev, have you ever signed off a git patch? Do you want to learn how to do that? Then your reviewing of the patch will nicely show up in the git history. ---------------------------------------------------------------------- Comment By: Sulev Sild (sulev) Date: 2010-12-24 14:20 Message: Thanks, the patch looks good! ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-12-21 14:33 Message: Hi Sulev, thanx for your review! The file name mismatch is because this patch was written before the class rename :) I also added a code example of setting IO properties and referred to the relevant CDK News paper. Please see the new attached patch. ---------------------------------------------------------------------- Comment By: Sulev Sild (sulev) Date: 2010-12-20 12:36 Message: Just few points: - replace "MDLWriter" with "MDLV2000Writer" in the code example. - Include example in the code example how to set IO settings Otherwise it's OK. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-10-21 19:22 Message: Patch for cdk-1.4.x attached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3029445&group_id=20024 |