From: Rajarshi G. <raj...@gm...> - 2010-10-24 13:16:06
|
On Oct 24, 2010, at 3:24 AM, Egon Willighagen wrote: > Rajarshi, > > On Sat, Oct 23, 2010 at 4:28 PM, Rajarshi Guha <raj...@gm... > > wrote: >> Hi, I have been investigating the conversion of *Set classes to >> classes based on List. Currently I have successfully converted >> RingSet >> (and IRingSet) to a subclass of ArrayList<IRing>. > > public class RingSet extends ArrayList<IRing> {} ? Right - but I think Nina's point is good - implementing List<IRing> would be better (but much more work) > I guess we should rename the class to RingList, fixing another of our > 'mistakes'. Correct - but renaming is easy :) >> The problem I am facing is the related to the construction of RingSet >> objects and the module structure. Given that RingSet no longer >> subclasses ICDKObject, it cannot be constructed via >> DefaultChemObjectBuilder. > > It cannot have a setup where "RingSet implements ICDKObject"? It could, but from what I understand DefaultChemObjectBuilder assumes that T (the supplied class) extends ICDKObject, so just having it implement the interface won't help (?) > I think I would need to see the code, but do you mean 'implement > ICDKObject' or 'subclass CDKObject'? subclass - see above comment > >> Are there any suggestions as to how this might be solved? > > Can you put up the code somewhere? Perhaps as Gist(s) (I think it > supports multiple files in one gist now)? I do not care about > compiling or not, just want to see what the code looks like... OK - I'll put it up on my github branch ---------------------------------------------------- Rajarshi Guha | NIH Chemical Genomics Center http://www.rguha.net | http://ncgc.nih.gov ---------------------------------------------------- The only perfect science is hindsight. |