[Cdk-devel] [ cdk-Patches-3032568 ] smsd molhandler doesn't close inputstreams

[SourceForge.net <no...@so...>]

Patches item #3032568, was opened at 2010-07-21 13:36
Message generated for change (Comment added) made by jkerssem
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3032568&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: master
Group: Needs Revision
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jules Kerssemakers (jkerssem)
Assigned to: Nobody/Anonymous (nobody)
Summary: smsd molhandler doesn't close inputstreams

Initial Comment:
The constructors for the cdk.smsd.helper.MolHandler that take a string filename do not close the MDLReader they open to read the file.
This leaks open files.
There should be a finally-block attached to the already existing try that closes the MDLReaders.

----------------------------------------------------------------------

Comment By: Jules Kerssemakers (jkerssem)
Date: 2010-08-02 12:11

Message:
Done, how is the new patch?
This time I made a branch from clean master against which I remade the
patch, including the requested logger calls..

I had a look at the bug you mentioned, and I reformatted my logging
statements accordingly.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2010-08-01 14:05

Message:
Jules, please see:

3037820	Weird use of the ILoggingTool in MolHandler

Please make the Logger call:

Logger.warn("Couldn't close molReader: ", e,getMessage());


----------------------------------------------------------------------

Comment By: Jules Kerssemakers (jkerssem)
Date: 2010-07-21 14:40

Message:
Made a patch that closes the input streams.
I used finally blocks attached to the existing try-s.
How is it?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3032568&group_id=20024