From: SourceForge.net <no...@so...> - 2010-07-15 23:56:22
|
Patches item #3018684, was opened at 2010-06-20 09:21 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.2.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:56 Message: Also I have to say the alternative patch is quite heavy weight. A whole class just for a version string? ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:52 Message: I'm not sure I understand. Shouldn't the source code change with a version change? (The sources only change if the version atually changes - if there is no change the source file does not get modified) ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-15 13:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |