[Cdk-devel] [ cdk-Patches-2986464 ] RGroupQueryWriter fix for O/S line separator

[SourceForge.net <no...@so...>]

Patches item #2986464, was opened at 2010-04-13 15:09
Message generated for change (Settings changed) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2986464&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: master
>Group: Accepted
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mark Rijnbeek (mark_rynbeek)
>Assigned to: Egon Willighagen (egonw)
Summary: RGroupQueryWriter fix for O/S line separator

Initial Comment:
The RGroupQueryWriter does not consistently use the System property "line.separator" when writing files.
On Windows, this leads to too many line breaks in the output files. This patch fixes that.

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2010-04-22 19:18

Message:
Looks good to me. Will apply to master.

BTW 1: please set your name and email in git:

$ git config --global user.name "Mark Rijnbeek"
$ git config --global user.email "mar...@us..."

BTW 2:

                } catch (IOException e) {
                        e.printStackTrace();
-                       throw new CDKException("Unexpected excpetion when
writing RGFile.\n"+e.getMessage());
+                       throw new CDKException("Unexpected exception when
writing RGFile"+LSEP+e.getMessage());
                }

you can pass the underlying Exception as second argument to the
CDKException constructor, so that the full stacktrace will be available for
debug:

throw new CDKException("some message", exception);

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2986464&group_id=20024