Re: [Cdk-devel] Junior issue 1816529

[Egon W. <ego...@gm...>]

Hi Uli,

On Sun, Nov 15, 2009 at 5:00 PM, Uli Köhler <uli...@on...> wrote:
> I fixed junior issue 1816529 by adding <IAtomContainer> to the Iterator
> declarations where neccessary.

Looks good, though you could have removed the cast to IAtomContainer
in situations like below (third line) to clean up the code further:

-                       for (Iterator substructureIterator =
mappedSubstructures.atomContainers().iterator();
substructureIterator.hasNext(); ) {
+                       for (Iterator<IAtomContainer>
substructureIterator =
mappedSubstructures.atomContainers().iterator();
substructureIterator.hasNext(); ) {
                                IAtomContainer substructure =
(IAtomContainer) substructureIterator.next();

Oh, and when you change a line, and it is not yet 80 chars or less,
please do wrap it to 80 characters.

Applied your patch to master.

Egon

-- 
Post-doc @ Uppsala University
Homepage: http://egonw.github.com/
Blog: http://chem-bla-ics.blogspot.com/
PubList: http://www.citeulike.org/user/egonw/tag/papers