Re: [Cdk-jchempaint] Patches from Arvid

[Stefan K. <ste...@eb...>]

On Thursday 15 October 2009 14:28:48 Egon Willighagen wrote:
> Hi Mark,
>
> Arvid has put a number of patches online:
>
> http://pele.farmbio.uu.se/cgi-bin/gitweb.cgi?p=gpox-jchempaint.git;a=shortl
>og;h=refs/heads/more-edit-patches
>
> Tomorrow I am starting to merge in JCP patches from him and the EBI...
> he showed me a demo yesterday, and the patches include:
>
> * further converting ControllerHub methods into IEdit implementations
> * drawing rings (etc) by having those show up as phantom structure
> * merge onto multiple atoms
The only comment I have is that a patch doing this was already made available 
by me on 29th of September: Patch 2869840, "AddRingModule shows phantom ring"
Stefan
>
> There is overlap with the patches from the EBI, so I'm going to have a
> though job getting patches merged into jchempaint-primary...
>
> If you have comments on his patches, please let them now.
>
> Egon



-- 
Stefan Kuhn B. Sc. M. A.
Software Engineer in the Chemoinformatics and Metabolism Team
European Bioinformatics Institute (EBI)
Wellcome Trust Genome Campus
Hinxton, Cambridge CB10 1SD UK
Phone +44 1223 49 2657
Fax +44 (0)1223 494 468