[Cdk-devel] [ cdk-Patches-2855925 ] Patch to solve bug #2855850: setStereo(IBond.Stereo)

[SourceForge.net <no...@so...>]

Patches item #2855925, was opened at 2009-09-10 06:54
Message generated for change (Comment added) made by rajarshi
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2855925&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch to solve bug #2855850: setStereo(IBond.Stereo)

Initial Comment:
Aimed as CDK master, so 1 senior review required, all other welcome.

The patch changes the CDK API for IBond.set/getStereo() to use IBond.Stereo (new) instead of int. Note that:

* there are minor code interpretations in SmilesGenerator, ModelBuilder3D and BondTools
* added two unit tests for MDL molfile reading to test the stereo type mapping

----------------------------------------------------------------------

>Comment By: Rajarshi Guha (rajarshi)
Date: 2009-09-12 00:25

Message:
Looks OK (though it'd be easier if the core changes were in a separate
patch). 


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2855925&group_id=20024