Re: [Cdk-jchempaint] bioclipse jcp code

[Mark R. <ma...@eb...>]

>  
> I had a hard time getting things to work and because the zoom/scroll 
> code lies
> outside the Renderer and thus is not shared between bioclipse and the 
> applet.
>
>
>     So can I then conclude that making changes in this particular method
>     will not affect bioclipse?
>
>  
> Yes

Ok, I'll make a patch later to drop the shift method from Renderer then, 
I'll put a corrected version of the shift method in RenderPanel instead.
If the code is not shared, it shouldn't be in jcp-primary I suppose.

>
>     More in general - how could I test this ? And how do the bioclipse
>     developers (the other way around) test for the effect changes have in
>     the applet?
>
>
> To be honest there has not been much in that way at all.
> The areas where changes affect the implementations differently is in 
> the zooming code
> and the interpretation of the Rendering elements.
>  
>
>
>     I suppose the best solution would be to exchange jcp-primary git
>     patches
>     both ways, so changes for the applet can be tested in bioclipse
>     and vice
>     versa.
>     Or was this already how things were envisaged?
>
>
> Pretty much, the Renderer and ControllerHub dose most of the work
> and the applet/bioclipse displays the result and inputs events.
> So changes should affect both in the same way.
>

That's clear, thanks.

Mark