From: Rajarshi G. <rg...@in...> - 2009-03-09 14:39:15
|
On Mar 9, 2009, at 10:31 AM, Noel O'Boyle wrote: > Here's a bash hack to identify functions which do nothing but return > null (a more sophisticated one might do better): > > $ for d in `/usr/bin/find -name "*.java"`; do result=`cat $d | tr -d > "\n\t" | grep -o "{return null;}" | wc -l`; if [ "0" != "$result" ] ; > then echo "$d has $result match(es)"; fi; done > > When run on the CDK 1.2.x branch, in the src/org directory, the > following results are found: > > ./qsar/descriptors/molecular/AutocorrelationDescriptorMass.java has > 2 match(es) Why is the above file in error? The two methods are: public Object getParameterType(String name) public Object[] getParameters() So if the descriptor has no params, returning null seems to make sense. (One could argue that the second method should return Object[] {}, but is that an issue?) For the second case you mentioned, that is clearly wrong! ------------------------------------------------------------------- Rajarshi Guha <rg...@in...> GPG Fingerprint: D070 5427 CC5B 7938 929C DD13 66A1 922C 51E7 9E84 ------------------------------------------------------------------- Q: What's polite and works for the phone company? A: A deferential operator. |