From: SourceForge.net <no...@so...> - 2008-12-02 23:01:33
|
Patches item #2378524, was opened at 2008-12-02 12:30 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2378524&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jonathan Alvarsson (jonalv) Assigned to: Nobody/Anonymous (nobody) Summary: further speedup of FingerPrinter Initial Comment: Caching of expensive calculating which turns out to be made many times. Also moved String declaration out of method which can be called quite a few times... ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2008-12-02 18:01 Message: Can you provide a patch against CDK Trunk - I can't apply your complete patch (1 chunk fails) but then I can't rebuild the distro since it seems that GraphOnlyFingerprinter was not updated. Also I get the error from Fingerprinter: [javac] /Users/rguha/src/java/cdk/trunk/build/src/standard/org/openscience/cdk/fingerprint/Fingerprinter.java:144: incompatible types [javac] found : java.util.Set<java.lang.String> [javac] required: java.util.Map<java.lang.String,java.lang.String> [javac] Map<String,String> paths = findPathes(container, searchDepth); [javac] ^ [javac] /Users/rguha/src/java/cdk/trunk/build/src/standard/org/openscience/cdk/fingerprint/Fingerprinter.java:220: cannot find symbol [javac] symbol : method put(java.lang.String,java.lang.String) [javac] location: interface java.util.Set<java.lang.String> [javac] for (String s : cleanPath) paths.put(s, s); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2378524&group_id=20024 |