Re: [Cdk-devel] Post CDK 1.0: Java5 required

[Egon W. <e.w...@sc...>]

On Wednesday 30 May 2007, Thorsten Meinl wrote:
> > These two things will require major rewritting of the core data classes,
> > but *critical* to CDK based work in the next year, of at least two CDK
> > developers.
>
> One thing you should also try to improve is thread-safety, especially if
> you plan to more or less restart from scratch. This is not only useful
> for tools like KNIME (;-)) but maybe also interesting if CDK is used in
> WebServices or the like, because there also multiple threads are used.

Yeah, forgot to mention that. This is very important indeed. That things are 
currently not thread safe, is not by design I think. Considering all the 
multicore machines being sold now and in the future, non-thread-safeness is a 
showstopper.

> One other thing you might try (though it's a bit time consuming), is
> actually some code reviewing, after classes habe been finished. Writing
> "only" testcases does not necessarily detect conceptual flaws but only
> actual bugs.

We have PMD tests to help in this area. Actually, code review happens when 
every patch is made. On the other side, every patch also makes the code more 
complex. Any help here is always much appreciated.

> As far as my time permits I'm willing to support you in these two
> things, but you should keep in mind, that I'm not a chemist, thus I
> cannot judge if some piece of code is semantically correct in all cases.

Any contribution is important.

Egon

-- 
e.w...@sc...
Blog: http://chem-bla-ics.blogspot.com/
GPG: 1024D/D6336BA6