Re: [Cdk-devel] [Cdk-commits] SF.net SVN: cdk: [7775] trunk/cdk/src/org/openscience/cdk/qsar/descriptors/ atomic/SigmaElectronegativityDescriptor.java

[Rajarshi G. <rg...@in...>]

On Mon, 2007-01-29 at 13:04 +0100, Egon Willighagen wrote:
> On Monday 29 January 2007, sh...@us... wrote:
> > @@ -102,6 +102,8 @@
> >          if (!(params[0] instanceof Integer) ){
> >              throw new CDKException("The parameter must be of type
> > Integer"); }
> > +        if(params.length==0)
> > +        	return;
> >          maxIterations = ((Integer) params[0]).intValue();
> >      }
> 
> Stefan,
> 
> I am not sure this is the right way to do this: fail silently when incorrect 
> input has been given. 

I strongly agree - if there is a problem, let the caller know.

This was a big issue when writing the descriptor GUI - it was running
OK, but I would get invalid numbers or I would have to make extra checks
to ensure that I was getting a value at all.

At least I can catch an exception and handle it :)

> The NPE it did before it not great either, but at least 
> shows that something is wrong in the code of the user of this class.

Agreed.

-------------------------------------------------------------------
Rajarshi Guha <rg...@in...>
GPG Fingerprint: 0CCA 8EE2 2EEB 25E2 AB04 06F7 1BB9 E634 9B87 56EE
-------------------------------------------------------------------
The emacs religion: to be saved, control excess...