From: SourceForge.net <no...@so...> - 2010-06-20 13:21:53
|
Patches item #3018684, was opened at 2010-06-20 09:21 Message generated for change (Tracker Item Submitted) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-07-15 17:22:04
|
Patches item #3018684, was opened at 2010-06-20 15:21 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-07-15 19:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-07-15 17:23:27
|
Patches item #3018684, was opened at 2010-06-20 15:21 Message generated for change (Settings changed) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: cdk-1.2.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-15 19:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-07-15 23:52:42
|
Patches item #3018684, was opened at 2010-06-20 09:21 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.2.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:52 Message: I'm not sure I understand. Shouldn't the source code change with a version change? (The sources only change if the version atually changes - if there is no change the source file does not get modified) ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-15 13:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-07-15 23:56:22
|
Patches item #3018684, was opened at 2010-06-20 09:21 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.2.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:56 Message: Also I have to say the alternative patch is quite heavy weight. A whole class just for a version string? ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:52 Message: I'm not sure I understand. Shouldn't the source code change with a version change? (The sources only change if the version atually changes - if there is no change the source file does not get modified) ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-15 13:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-07-16 05:21:32
|
Patches item #3018684, was opened at 2010-06-20 15:21 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.2.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-07-16 07:21 Message: > Shouldn't the source code change with a version change? Why should it? Surely the functionality must change, but the code to return the version number? > The sources only change if the version atually changes But it increases the number of files that will change... for each version change there are then two files to commit, instead of one. > A whole class just for a version string? The class might provide more information later... but I kind of liked the idea of being able to do CDK.getVersion()... CDKConstants does not sound like the correct place for a method, so did not want to place it there, but I am open to suggestions of other (existing) classes... ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-16 01:56 Message: Also I have to say the alternative patch is quite heavy weight. A whole class just for a version string? ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-16 01:52 Message: I'm not sure I understand. Shouldn't the source code change with a version change? (The sources only change if the version atually changes - if there is no change the source file does not get modified) ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-15 19:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-08-29 20:24:00
|
Patches item #3018684, was opened at 2010-06-20 09:21 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.2.x >Group: Accepted >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Egon Willighagen (egonw) Summary: Add a constant to indicate library version Initial Comment: The attached patch adds a contant to indicate the current library version. It gets updated by a build target in the customization step of the build process and only chnages the file (CDKConstants.java) if the version actually changes ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-08-29 16:23 Message: I'm going with Egons patch, s it seemed to be more generally accepted. Applied and pushed ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-16 01:21 Message: > Shouldn't the source code change with a version change? Why should it? Surely the functionality must change, but the code to return the version number? > The sources only change if the version atually changes But it increases the number of files that will change... for each version change there are then two files to commit, instead of one. > A whole class just for a version string? The class might provide more information later... but I kind of liked the idea of being able to do CDK.getVersion()... CDKConstants does not sound like the correct place for a method, so did not want to place it there, but I am open to suggestions of other (existing) classes... ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:56 Message: Also I have to say the alternative patch is quite heavy weight. A whole class just for a version string? ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-07-15 19:52 Message: I'm not sure I understand. Shouldn't the source code change with a version change? (The sources only change if the version atually changes - if there is no change the source file does not get modified) ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-07-15 13:22 Message: I'm not so fond of that patch, as each version change will now change the source code. I attached an alternative patch which reads the version number from the build.props on runtime. I made my patch against cdk-1.2.x as I think this is a useful addition to the library, particularly for comparing CDK 1.2 version 1.3/1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3018684&group_id=20024 |