SourceForge has been redesigned. Learn more.
Close

#1104 Unnessecry methods in OWL reader

cdk-1.4.x
closed
5
2012-11-03
2010-10-17
No

In the OWL reader, you have

  • public IChemObject read(IChemObject object) throws CDKException {
  • if (object instanceof IMolecule) {
  • return readMolecule((IMolecule)object);
  • } else {
  • throw new CDKException(
  • "Only supported is reading of IMolecule objects."
  • );
  • }
  • }

but readMolecule(IMolecule) is a private method that just returns the
input argument? I think you could drop this private method and just return
the molecule. Or is there a reason for it being there?

Discussion

  • Egon Willighagen

    Patch was applied.