Menu
▾
▴
4 Attachments
#59 compiler warnings
I know this is lagcy code and all, but I think it's still a good idea to fix as many compiler warnings as possible so that eventually one can build with "-Wall" enabled without the screen being spammed with warnings.
I'm especially thinking about the -Wformat warnings, as some of them (as far as I know) might be security related: https://gcc.gnu.org/onlinedocs/gcc-3.4.4/gcc/Warning-Options.html#index-Wformat_002dsecurity-198
I've attached some patches that I made for release 2.2.4 showing you what I mean.
There are tons of these - thousands of them actually. In cde-fixups-1 branch, there has been some work to try to address many of these issues. Unfortunately, this is likely a long term effort, and we may never be able to get a -Wall clean build with some of the stuff in there :)
I'll mark this as "pending" with a "Help wanted" tag. This issue will be around for awhile.
Feel free to post patches to the mailing list or submit a pull request if you want to tackle some of them.