cdesktopenv-devel — Discussions related to CDE development.

Re: [cdesktopenv-devel] Cannot compile CDE on Debian 11

[TCH <tc...@pr...>]

Hello,

Yes, it is installed, at least there is an rpcgen binary in /usr/bin, installed by the package libc-dev-bin.

- TCH

Sent with Proton Mail secure email.

On Tuesday, November 14th, 2023 at 8:41 PM, Jon Trulson <jo...@ra...> wrote:


> On 11/14/23 09:30, TCH via cdesktopenv-devel wrote:
> 
> > Hello,
> 
> 
> Hi,
> 
> Just taking a stab here, but do you have rpcgen installed? It should build on debian 11. debian 12 requires you pull from master git.
> 
> -jon
> 
> 
> > I've tried to compile CDE on Debian 11 (x86_64), following the build instructions to the letter (installing all required packages, etc.) and compiling with ./autogen.sh, ./configure and make, but the compiler cannot compile it, due missing definitions/constants/etc.
> > The compiler is GCC 10.2.1, Motif is 2.3.8. The error messages were the following:
> > ================================================================================
> > agent.c: In function ‘_DtCm_init_agent’:
> > agent.c:145:43: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
> >   145 |         (void)pmap_unset(_DtCm_transient, AGENTVERS);
> >       |                                           ^~~~~~~~~
> >       |                                           AGENTVERS_2
> > agent.c:145:43: note: each undeclared identifier is reported only once for each function it appears in
> > agent.c:152:46: error: ‘update_callback’ undeclared (first use in this function)
> >   152 |  if (registerrpc(_DtCm_transient, AGENTVERS, update_callback,
> >       |                                              ^~~~~~~~~~~~~~~
> > agent.c:153:25: error: ‘_DtCm_update_callback_1’ undeclared (first use in this function); did you mean ‘cmcb_update_callback_2’?
> >   153 |      (char *(*)(char *))_DtCm_update_callback_1, (xdrproc_t)_DtCm_xdr_Table_Res_4,
> >       |                         ^~~~~~~~~~~~~~~~~~~~~~~
> >       |                         cmcb_update_callback_2
> > agent.c:154:17: error: ‘_DtCm_xdr_Update_Status’ undeclared (first use in this function); did you mean ‘_DtCm_xdr_Appt_Status_4’?
> >   154 |      (xdrproc_t)_DtCm_xdr_Update_Status) == -1) {
> >       |                 ^~~~~~~~~~~~~~~~~~~~~~~
> >       |                 _DtCm_xdr_Appt_Status_4
> > agent.c: In function ‘_DtCm_destroy_agent’:
> > agent.c:187:44: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
> >   187 |         (void) pmap_unset(_DtCm_transient, AGENTVERS);
> >       |                                            ^~~~~~~~~
> >       |                                            AGENTVERS_2
> > agent.c: At top level:
> > agent.c:292:1: error: unknown type name ‘Update_Status’
> >   292 | Update_Status *
> >       | ^~~~~~~~~~~~~
> > agent.c: In function ‘_DtCm_update_callback_1’:
> > agent.c:295:9: error: unknown type name ‘Update_Status’
> >   295 |  static Update_Status status = update_succeeded;
> >       |         ^~~~~~~~~~~~~
> > agent.c:295:32: error: ‘update_succeeded’ undeclared (first use in this function)
> >   295 |  static Update_Status status = update_succeeded;
> >       |                                ^~~~~~~~~~~~~~~~
> > agent.c:307:15: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
> >   307 |   cbi->vers = AGENTVERS;
> >       |               ^~~~~~~~~
> >       |               AGENTVERS_2
> > agent.c: In function ‘_DtCm_handle_callback’:
> > agent.c:467:20: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
> >   467 |   if (ptr->vers == AGENTVERS)
> >       |                    ^~~~~~~~~
> >       |                    AGENTVERS_2
> > ================================================================================
> > Is this a bug, or on Debian 11, something else is needed?
> > 
> > - TCH
> > 
> > Sent with Proton Mail secure email.
> > 
> > 
> > _______________________________________________
> > cdesktopenv-devel mailing list
> > cde...@li...
> > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
> 
> 
> 
> --
> Jon Trulson
> 
>   "The less you know, the more you believe."
>                            -- Bono

Re: [cdesktopenv-devel] Cannot compile CDE on Debian 11

[Jon T. <jo...@ra...>]

On 11/14/23 09:30, TCH via cdesktopenv-devel wrote:
> Hello,

Hi,

Just taking a stab here, but do you have rpcgen installed?  It should 
build on debian 11.  debian 12 requires you pull from master git.

-jon

> I've tried to compile CDE on Debian 11 (x86_64), following the build instructions to the letter (installing all required packages, etc.) and compiling with ./autogen.sh, ./configure and make, but the compiler cannot compile it, due missing definitions/constants/etc.
> The compiler is GCC 10.2.1, Motif is 2.3.8. The error messages were the following:
> ================================================================================
> agent.c: In function ‘_DtCm_init_agent’:
> agent.c:145:43: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
>    145 |         (void)pmap_unset(_DtCm_transient, AGENTVERS);
>        |                                           ^~~~~~~~~
>        |                                           AGENTVERS_2
> agent.c:145:43: note: each undeclared identifier is reported only once for each function it appears in
> agent.c:152:46: error: ‘update_callback’ undeclared (first use in this function)
>    152 |  if (registerrpc(_DtCm_transient, AGENTVERS, update_callback,
>        |                                              ^~~~~~~~~~~~~~~
> agent.c:153:25: error: ‘_DtCm_update_callback_1’ undeclared (first use in this function); did you mean ‘cmcb_update_callback_2’?
>    153 |      (char *(*)(char *))_DtCm_update_callback_1, (xdrproc_t)_DtCm_xdr_Table_Res_4,
>        |                         ^~~~~~~~~~~~~~~~~~~~~~~
>        |                         cmcb_update_callback_2
> agent.c:154:17: error: ‘_DtCm_xdr_Update_Status’ undeclared (first use in this function); did you mean ‘_DtCm_xdr_Appt_Status_4’?
>    154 |      (xdrproc_t)_DtCm_xdr_Update_Status) == -1) {
>        |                 ^~~~~~~~~~~~~~~~~~~~~~~
>        |                 _DtCm_xdr_Appt_Status_4
> agent.c: In function ‘_DtCm_destroy_agent’:
> agent.c:187:44: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
>    187 |         (void) pmap_unset(_DtCm_transient, AGENTVERS);
>        |                                            ^~~~~~~~~
>        |                                            AGENTVERS_2
> agent.c: At top level:
> agent.c:292:1: error: unknown type name ‘Update_Status’
>    292 | Update_Status *
>        | ^~~~~~~~~~~~~
> agent.c: In function ‘_DtCm_update_callback_1’:
> agent.c:295:9: error: unknown type name ‘Update_Status’
>    295 |  static Update_Status status = update_succeeded;
>        |         ^~~~~~~~~~~~~
> agent.c:295:32: error: ‘update_succeeded’ undeclared (first use in this function)
>    295 |  static Update_Status status = update_succeeded;
>        |                                ^~~~~~~~~~~~~~~~
> agent.c:307:15: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
>    307 |   cbi->vers = AGENTVERS;
>        |               ^~~~~~~~~
>        |               AGENTVERS_2
> agent.c: In function ‘_DtCm_handle_callback’:
> agent.c:467:20: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
>    467 |   if (ptr->vers == AGENTVERS)
>        |                    ^~~~~~~~~
>        |                    AGENTVERS_2
> ================================================================================
> Is this a bug, or on Debian 11, something else is needed?
>
> - TCH
>
> Sent with Proton Mail secure email.
>
>
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono

[cdesktopenv-devel] Want to release a 2.5.2 next week

[Jon T. <jo...@ra...>]

Hi,

It' s been awhile, and I'll have some time next week to do a 2.5.2 
release - this would be a bugfix release, no new features.

Just an FYI in case someone is sitting on some patches they want to get in.

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono

[cdesktopenv-devel] Cannot compile CDE on Debian 11

[TCH <tc...@pr...>]

Hello,

I've tried to compile CDE on Debian 11 (x86_64), following the build instructions to the letter (installing all required packages, etc.) and compiling with ./autogen.sh, ./configure and make, but the compiler cannot compile it, due missing definitions/constants/etc.
The compiler is GCC 10.2.1, Motif is 2.3.8. The error messages were the following:
================================================================================
agent.c: In function ‘_DtCm_init_agent’:
agent.c:145:43: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
  145 |         (void)pmap_unset(_DtCm_transient, AGENTVERS);
      |                                           ^~~~~~~~~
      |                                           AGENTVERS_2
agent.c:145:43: note: each undeclared identifier is reported only once for each function it appears in
agent.c:152:46: error: ‘update_callback’ undeclared (first use in this function)
  152 |  if (registerrpc(_DtCm_transient, AGENTVERS, update_callback,
      |                                              ^~~~~~~~~~~~~~~
agent.c:153:25: error: ‘_DtCm_update_callback_1’ undeclared (first use in this function); did you mean ‘cmcb_update_callback_2’?
  153 |      (char *(*)(char *))_DtCm_update_callback_1, (xdrproc_t)_DtCm_xdr_Table_Res_4,
      |                         ^~~~~~~~~~~~~~~~~~~~~~~
      |                         cmcb_update_callback_2
agent.c:154:17: error: ‘_DtCm_xdr_Update_Status’ undeclared (first use in this function); did you mean ‘_DtCm_xdr_Appt_Status_4’?
  154 |      (xdrproc_t)_DtCm_xdr_Update_Status) == -1) {
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
      |                 _DtCm_xdr_Appt_Status_4
agent.c: In function ‘_DtCm_destroy_agent’:
agent.c:187:44: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
  187 |         (void) pmap_unset(_DtCm_transient, AGENTVERS);
      |                                            ^~~~~~~~~
      |                                            AGENTVERS_2
agent.c: At top level:
agent.c:292:1: error: unknown type name ‘Update_Status’
  292 | Update_Status *
      | ^~~~~~~~~~~~~
agent.c: In function ‘_DtCm_update_callback_1’:
agent.c:295:9: error: unknown type name ‘Update_Status’
  295 |  static Update_Status status = update_succeeded;
      |         ^~~~~~~~~~~~~
agent.c:295:32: error: ‘update_succeeded’ undeclared (first use in this function)
  295 |  static Update_Status status = update_succeeded;
      |                                ^~~~~~~~~~~~~~~~
agent.c:307:15: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
  307 |   cbi->vers = AGENTVERS;
      |               ^~~~~~~~~
      |               AGENTVERS_2
agent.c: In function ‘_DtCm_handle_callback’:
agent.c:467:20: error: ‘AGENTVERS’ undeclared (first use in this function); did you mean ‘AGENTVERS_2’?
  467 |   if (ptr->vers == AGENTVERS)
      |                    ^~~~~~~~~
      |                    AGENTVERS_2
================================================================================
Is this a bug, or on Debian 11, something else is needed?

- TCH

Sent with Proton Mail secure email.

Re: [cdesktopenv-devel] CDE on Raspberry Pi 4 (64-bit OS) possible tweaks?

[Edmond O. <edm...@wa...>]

Le 01/06/2023 à 08:55, Johannes von Rotz a écrit :
> On 5/31/23 19:46, Richard L. Hamilton wrote:
>> I can e.g. run dtpad from a command, although it takes a long time to start, since ttdbserverd and/or ttesssion are not running.
> Hi Richard
>
>
>> * add a session to those CDE knows about
> I had some success with something like this:
>
> $ cat > /usr/dt/config/C/Xresources.d/Xresources.twm <<EOF
> Dtlogin*altDtName1:     Twm
> Dtlogin*altDtKey1:      /usr/bin/twm
> Dtlogin*altDtStart1:    /usr/bin/twm
> Dtlogin*altDtLogon1:    Twm
> EOF
>
> According to the dtlogin man page, you define an Xresources.* file for
> each session type and append an incrementing number to each of those
> resource definitions. So if you have another windows manager you would
> like to use, you define altDtName2, altDtKey2, etc.
>
> I haven't yet figured out why there's an altDtKey and an altDtStart
> resource. But we'll get there...

I have used the following configuration file:

Dtlogin*altDtsIncrement:        True

Dtlogin*altDtName:      Window Maker
Dtlogin*altDtKey:       /usr/bin/wmaker
Dtlogin*altDtStart:     /etc/dt/config/Xsession.windowmaker
Dtlogin*altDtLogo:     /usr/share/WindowMaker/Icons/GNUstep.xpm

named 0300.session under /etc/dt/config/C/Xresources.d

altDtKey is any file that is present when the window manager is 
installed (here the executable),

altDtStart the startup script

and /etc/dt/config/Xsession.windowmaker

contains

#!/bin/ksh

WINDOW_MANAGER=/usr/bin/wmaker

export WINDOW_MANAGER

exec /usr/bin/wmaker

It is also possible to stop the computer by defining a session with a 
script that executes

shutdown -h now instead of a window manager. If the computer accepts 
suspend to disk,

it can be also  suspended with echo disk >/sys/power/state.

>> And what has changed since CDE went open source to the extent that something might be replaced with something else not natively CDE, or might otherwise be unfamiliar?
> We don't like change. :)
>
> Cheers, J.
>
>
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Re: [cdesktopenv-devel] CDE on Raspberry Pi 4 (64-bit OS) possible tweaks?

[Johannes v. R. <jr...@vr...>]

On 5/31/23 19:46, Richard L. Hamilton wrote:
> I can e.g. run dtpad from a command, although it takes a long time to start, since ttdbserverd and/or ttesssion are not running.

Hi Richard

I remember resolving a few issues like that by adding the hostname of
the machine to /etc/hosts pointing to 127.0.0.1. Have you looked into
/var/dt/Xerrors or ~/.dt/errorlog?

> * start those while still using the native (lightdm) windown and session management?

Something like that works on my Debian (aarch64) machine:

$ cat > /usr/share/xsessions/cde.desktop <<EOF
[Desktop Entry]
Name=CDE
Comment=This session logs you into the Common Desktop Environment
Exec=/usr/dt/bin/Xsession
TryExec=/usr/dt/bin/Xsession
Icon=
Type=Application
DesktopNames=CDE
EOF

> * add a session to those CDE knows about

I had some success with something like this:

$ cat > /usr/dt/config/C/Xresources.d/Xresources.twm <<EOF
Dtlogin*altDtName1:     Twm
Dtlogin*altDtKey1:      /usr/bin/twm
Dtlogin*altDtStart1:    /usr/bin/twm
Dtlogin*altDtLogon1:    Twm
EOF

According to the dtlogin man page, you define an Xresources.* file for
each session type and append an incrementing number to each of those
resource definitions. So if you have another windows manager you would
like to use, you define altDtName2, altDtKey2, etc.

I haven't yet figured out why there's an altDtKey and an altDtStart
resource. But we'll get there...

> And what has changed since CDE went open source to the extent that something might be replaced with something else not natively CDE, or might otherwise be unfamiliar?

We don't like change. :)

Cheers, J.

[cdesktopenv-devel] CDE on Raspberry Pi 4 (64-bit OS) possible tweaks?

[Richard L. H. <rl...@sm...>]

Context: my CDE experience is on Solaris 10 and earlier, almost entirely. On there, I've read, scrounged, and done enough to be able to tweak it quite a bit - like a command line tool that can send f. commands to dtwm, so things like restarting dtwm after editing a dtwmrc file can be scripted. But that was a long time ago. :-) I had some years ago built with mixed results CDE for Solaris 11 (SPARC).
 
I just installed CDE on a Raspberry Pi 4 (current and regularly updated 64-bit Bullseye for the Raspberry Pi, with some 32-bit packages installed as well to support ExpressVPN client which is only 32-bit).

https://sourceforge.net/p/cdesktopenv/wiki/CDE%20on%20the%20Raspberry%20Pi/ <https://sourceforge.net/p/cdesktopenv/wiki/CDE%20on%20the%20Raspberry%20Pi/> clearly needs updating, because it describes the older build procedure without automake and ./configure.

Some extra packages were needed (automake was obvious, plus a couple more, one I forget), the least obvious of which being opensp, since the package name isn't obvious from the onsgmls binary needed. I wish I'd taken notes, but I'm not likely to have another Raspberry to do this on, so I didn't think of it at the time.

Late in the build, I had to switch to doing it from an ssh connection, to finishing from a terminal window in a desktop session, because the build wanted to communicate with the X server or something present in a desktop session. Fortunately an interrupted make will tend to pick up where it left off.

Other than those points (some of which are addressed by the README.md file), there were a few compiler warnings but no failures in building.

I can e.g. run dtpad from a command, although it takes a long time to start, since ttdbserverd and/or ttesssion are not running.

How can I:

* start those while still using the native (lightdm) windown and session management?

* add a session to those CDE knows about (e.g. on Solaris, one could from the CDE login choose not only a CDE session, but others, such as GNOME or on older Solaris, OpenLook, or add some, even as wild as OpenStep if one had it (I have the Sun build of that for SPARC Solaris), or lightweight like fvwm or plain mwm or twm. In particular, I want a way to have dtlogin be able to start a login session functionally equivalent as much as possible to the native one. I remember /etc/dt/config/Xsession.* files for this, but it's been about 15 year (from the timestamps) since I added a session, so I've forgotten more about CDE than I know about lightdm. :-)

The point would be to have a choice of either lighdtm (if it can handle user choice of sessions at login time) or CDE login screen lead to either desktop with the tools of both other than the window manager (and those requiring it) being fully available. I want nostalgia and familiarity without breaking too much new stuff. :-) And preferably with some idea what configuration files I have to back up lest a package update clobber them.

And what has changed since CDE went open source to the extent that something might be replaced with something else not natively CDE, or might otherwise be unfamiliar?

[cdesktopenv-devel] XNedit and dtfile

[Edmond O. <edm...@wa...>]

Dear fellow CDE users,

There is on sourceforge a version of Nirvana Editor (NEdit) that can 
work with UTF-8 encoding called XNEdit.

  https://sourceforge.net/p/xnedit/code/ci/master/tree/

For the older NEdit, that only accepted ISO8859-1 encoding, there was a 
patch by Per Grahn

that allowed to use the drag and drop protocol of CDE to take a file in 
dtfile and open it by dropping

it on NEdit. I have tried to apply that patch on XNEdit and it turned 
out that it worked after very minimal

changes on Ubuntu 22.04 with CDE 2.5.1. I have submitted that patch to 
the XNEdit developpers, and

they have merged it in XNEdit source. They have also checked that it 
worked in FreeBSD. It is not enabled

by default, but there are comments in the makefile.linux explaining how 
to do so.

I am posting this message in case some users of the other platforms 
(Net/OpenBSD, OpenIndiana) would

want to try that patch as well.

Maybe a mention of XNEdit and how to enable the patch could be added to 
the CDE wiki.

Best,

E. Orignac

[cdesktopenv-devel] Script to convert XML mime type definitions to .dt

[Edmond O. <edm...@wa...>]

Here is a script that takes XML files under /usr/share/mime to create 
type definitions

in the format of a .dt file.

Example of use:

awk -f xml2dt.awk </usr/share/mime/text/x-adasrc.xml

output:

ATA_ATTRIBUTES   ADB
{
ACTIONS Open
ICON    Dtdata
IS_TEXT true
NAME_TEMPLATE     %s.adb
MIME_TYPE       text/x-adasrc
DESCRIPTION     This is a file containing   Ada source code.\
                 Its data type is named   ADB.
TYPE_LABEL        ADB
}

DATA_CRITERIA   ADB1
         {
         DATA_ATTRIBUTES_NAME      ADB
         MODE    f
         NAME_PATTERN    *.[Aa][Dd][Bb]
         }
DATA_CRITERIA   ADB2
         {
         DATA_ATTRIBUTES_NAME      ADB
         MODE    f
         NAME_PATTERN    *.[Aa][Dd][Ss]
         }

This script can be used with Isaac Dunham's desktop2dt. desktop2dt is 
used to generate

the actions, and xml2dt generates the associated datatypes.

[cdesktopenv-devel] dtlogin and alternative desktops

[Edmond O. <edm...@wa...>]

I have remarked an oddity with alternative desktop definitions in dtlogin.

If I create under /etc/dt/config/C/Xresources.d/

a file 250.session with content

Dtlogin*altDtsIncrement: True
Dtlogin*altDtName: MWM
Dtlogin*altDtKey: /usr/bin/mwm
Dtlogin*altDtStart: /etc/dt/config/Xsession.mwm
Dtlogin*altDtLogo: /usr/share/icons/mwm.xpm

and the script Xsession.mwm starts the Motif Window Manager, I am shown 
MWM among

the possible sessions, but If I pick an MWM session, CDE starts instead 
of MWM.

However, if I first define a language, say fr_FR.UTF-8, and then choose 
MWM I start the Motif Window Manager. Moreover, even if I choose C as 
the locale, in the language menu, MWM will start.

I have seen that behavior in CDE 2.4.0 with PAM enabled on Slackware 
15.0 32bit intel. I suspect it is

caused by an undefined locale when dtlogin starts. I am curious if the 
same behavior has been seen

on different configurations.

[cdesktopenv-devel] Some Cyrillic text is displayed with Japanese fonts

[Danila S. <d.s...@ra...>]

Hello,

I'm using ru_RU.UTF-8 locale with CDE 2.5.1 and some Cyrillic texts
look garbled. More specifically they do in the name of the month on the
panel, directory names in dtfile and windows' title bars. When
experimenting with /usr/dt/etc/cde/fontaliases/fonts.alias I've found
out that removing aliases for jisx0208.1983-0 encoding makes these texts
undisplayable. Also they look fine when the environment is run with
en_US.UTF-8 locale. Is there a way to give them the same look in
Russian locale?

Thank you.

Re: [cdesktopenv-devel] CDE 2.5.1 now on pkgsrc

[Jon T. <jo...@ra...>]

On 2/23/23 13:07, Paolo Vincenzo Olivo wrote:
> Dear CDE developers,
>
> CDE 2.5.1 has just been imported in the pkgsrc main tree as wm/cde
> [1]. Tested and working on NetBSD 10.0_BETA.
>
> The current official installation guide for NetBSD could be
> probably revised in light of what can be found inside the package
> Makefile/options.mk and the READMEs found in the _files_ subdirectory;
>
> Some of the patches applied may also be worth consideration.
> Any suggestion and feedback well appreciated.
>
> [1]http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/wm/cde/

Fantastic.  If you have a SF account I can add you as a member so you an 
edit the wiki - just send me your SF usename via private email.

If not, I'll look over some of this stuff over the weekend and see about 
cleaning up some of the netbsd wiki content on SF.  I'll checkout the 
patches too - it's always best to have them upstream where possible.

Thanks!

-jon

> Regards
>
>
>
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono

[cdesktopenv-devel] CDE 2.5.1 now on pkgsrc

[Paolo V. O. <vi...@Ne...>]

Dear CDE developers,

CDE 2.5.1 has just been imported in the pkgsrc main tree as wm/cde
[1]. Tested and working on NetBSD 10.0_BETA. 

The current official installation guide for NetBSD could be
probably revised in light of what can be found inside the package
Makefile/options.mk and the READMEs found in the _files_ subdirectory;

Some of the patches applied may also be worth consideration.   
Any suggestion and feedback well appreciated. 

[1]  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/wm/cde/

Regards

-- 
PVO | https://retrobsd.ddns.net

Re: [cdesktopenv-devel] [PATCH] Fix build under LLVM15

[Cy S. <Cy....@cs...>]

In message <351...@ra...>, Jon Trulson 
writ
es:
> This is a multi-part message in MIME format.
> --===============3445952125607115813==
> Content-Type: multipart/alternative;
>  boundary="------------gk9Qmvy2hZOT1KTlo52R5nsS"
> Content-Language: en-US
>
> This is a multi-part message in MIME format.
> --------------gk9Qmvy2hZOT1KTlo52R5nsS
> Content-Type: text/plain; charset=UTF-8; format=flowed
> Content-Transfer-Encoding: 8bit
>
> On 2/16/23 08:50, Cy Schubert wrote:
> > On Thu, 16 Feb 2023 14:30:41 +0000
> > Chase<nic...@pr...>  wrote:
> >
> >> You must not directly edit any file under ksh93, instead, pull the newest 
> point release from the source and merge it. Its a git subtree so I'm not quit
> e sure how that works.
> > I know how it works. We at FreeBSD use subtrees for vendor branches
> > (contributed code). (We have ATM decided to use subtrees instead
> > of submodules but that may change in the future.) Though, we sometimes
> > apply our own patches to /usr/src/contrib which are eventually
> > upstreamed, while other times we submit a patch and wait.
> >
> > I've updated the FreeBSD ksh ports with the same atomics patch. I plan
> > on upstreaming that too. Just haven't gotten around to it yet.
> >
> > I'll resubmit the patch minus the ksh bit.
> >
>
> I think I will apply this patch as-is for now.  Chase has a point in 
> that it causes conflicts the next time we want to resync with upstream 
> ksh, but I have no idea how long it will take for:
>
> - the patch to make it into ksh (https://github.com/ksh93/ksh/pull/601)
> - CDE to resync with upstream
>
> Plus this issue causes FTBFS
>
> So, let's throw all caution to the wind and apply it for now.
>
> Though I am suspicious of the ksh fix - it seems incongruous to check 
> for defined(_aso_casptr), but then instead use _aso_cas64()...  So not 
> sure if that will be considered correct from a ksh maintainer 
> perspective.  Guess we will see :)

As maintainer of the FreeBSD ksh family of ports, a ksh pull request has 
also been submitted. No reply so far. The alternative is 
-Wno-int-conversion when building aso.c until the error is fixed.


-- 
Cheers,
Cy Schubert <Cy....@cs...>
FreeBSD UNIX:  <cy...@Fr...>   Web:  https://FreeBSD.org
NTP:           <cy...@nw...>    Web:  https://nwtime.org

			e^(i*pi)+1=0

Re: [cdesktopenv-devel] Various issues with cde 2.5.1

[Jon T. <jo...@ra...>]

On 2/13/23 23:09, Giacomo Comes wrote:
> Hi,
> I'm in the process of packaging CDE for opensuse.
> While doing that I have found some issues and I have some doubts
> that I would like to share with you.

Gulp.

> 1) CDE does not compile with gcc12. In many places it throws the error:
>    error: control reaches end of non-void function [-Werror=return-type]
> Attached there is a patch that makes CDE 2.5.1 compile with gcc12.
> Please use such patch only as reference to see which functions
> have problems. Do not consider the patch correct C code.
> I just put some return statements here and there assuming
> that whatever value was returned it would be ignored.
> The purpose was only to have the build process proceed without errors
> in order to find all the troubling functions.
> While now urgent, this task needs to be done at some point.

Yeah, and the patch is not in git 'format-patch' format either which as 
I mentioned earlier causes more work to integrate, so I will not apply.

I can see that at least one of those changes is wrong anyway:

  static void *strmove(void *dest, const void *src) {
      memmove(dest, src, strlen(src) + 1);
+    return(0);
  }

This function should just:

return memmove(dest, src, strlen(src) + 1);

I'll fix that one myself.

>
> 2) If CDE is build with --prefix=/ust/dt (the default),
> many binaries have rpath set. Since that is forbidden
> by opensuse packaging rules, I'm forced to use the command
> chrpath on such binaries.
> configure has the option '--disable-rpath' but it does not seems to
> work. Using such options or not does not make any difference.
> Perhaps some Makefile.am needs adjust?

Hmmm... That will require investigation.

Seems this is handled by libtool, and apparently not very well. Post 
processing with chrpath might be the only way.


>
> 3) I have seen that in 2.5.1 only dtappgather is setuid.
> In the past the list was bigger. Is that correct?
> Is there any possibility that in the future no setuid
> program will be necessary?
>

Yes, we've slowly been whittling these down.  only appgather is suid 
root now.  I think the fix for that is to not bother setting up the 
application symlinks in /var/dt - rather just set them up in the user's 
.dt/... directory hierarchy somehwere and have dtfile, etc look there 
instead.

A patch(es) is welcome.

I'll probably tackle it someday when I get the time.

> 4) When I run dtbuilder, if I click on any widget in the main
> window the program crashes showing the following error messages:
>
> X Error of failed request:  BadAlloc (insufficient resources for operation)
>    Major opcode of failed request:  53 (X_CreatePixmap)
>    Serial number of failed request:  14181
>    Current serial number in output stream:  14184
>

No idea on that one.  dtbuilder needs a lot of work.

> 5) Since 2.5.0 if I start from a terminal some CDE programs
> (dtterm, dtpad, dtinfo, etc.) the following warning appears:
>    Warning: Missing charset in String to FontSet conversion
>    Warning: Missing charset in String to FontSet conversion
> That didn't happens in CDE up to 2.4.0

I've seen that too and is probably the result of some of the recent font 
changes that went in for utf8 support.  Would be nice to know what 
charsets are actually 'missing' here.

Unfortunately I'm not a font guy.  Not sure what's missing and what it 
would take to fix.

>
> 6) In the file contrib/desktopentry/cde.desktop
> it would be a good idea to add the line:
>    DesktopNames=CDE
> In this way, after a login, the desktop manager will set the environment variables:
> XDG_CURRENT_DESKTOP and XDG_SESSION_DESKTOP

Done.

>   
>
> 7) In the file programs/types/pgadmin.dt the line:
>       ICON          pgadmin
> should be:
>       ICON          pgadmin3

Done.

>
> 8) /usr/dt/bin/dterror.ds does not work properly in CDE 2.5.x
> It is build using programs/dtfile/dterror.src as source,
> but is should be using programs/types/error.ds.src as source.
> See databases/CDE-RUN.src in CDE up to 2.4.0

Hmm. yes, that one has the interpreter line set incorrectly to /etc/dt/...

Fixed.

But these scripts are not the same. They could possibly be made the same 
someday.  Patch (in git's format-patch format please) welcome.

>
> 9) the command:
>    ksh -c 'echo "\n"'
> prints a new line as output. So did the command:
>    dtksh -c 'echo "\n"'
> in CDE up to 2.3.2.
> Since 2.4.0 instead the same dtksh command prints: \n
> To restore the correct behavior ECHOPRINT=1 must be set
> in programs/dtksh/ksh93/src/cmd/ksh93/SHOPT.sh
>

This option might have been lost when I redid the way we set SHOPTS for 
the ksh93 build.

Fixed.

> 10) If, for example, I execure the action: ApplicationManager/Desktop_Tools/Environment Variables,
> in the output window I see at the end:
> ------------
> \n*** Select Close or Exit from the window menu to close this window ***
> ------------
> instead of:
> ------------
>
> *** Select Close or Exit from the window menu to close this window ***
> ------------
> The problem seems to be that many dtactions use: sh -c '...; echo ...\n...'
> in order to print a new line. Since, on linux, generally sh is bash, echo -e '\n'
> is required to print the new line. On a system where sh is a different shell
> (zsh, ksh, dash) echo will work as expected.
> My workaround for linux is to replace: 'sh -c' with: 'ksh -c'
> For that purpose I use the following command:
>    sed -i 's@\([[:blank:]]\)\(sh -c\)@\1k\2@' programs/types/*.{dt,src}
> I guess such change should work for any architecture.

Hmm.  Would it make sense to just use use dtksh for all of these?

>
> 11) the session is not saved correctly for dtterm, dtpad and dticon.
> In CDE 2.5; If you open dtterm or dtpad and logout, on the next login
> such windows are not restored.
> In the files programs/dticon/utils.c, programs/dtpad/session.c and
> programs/dtterm/DtTermMain.c there is code like this:
>    sprintf(buf, "%s some further text", buf)
> The C99 and POSIX.1-2001 standard specify that the result is undefined,
> I think that since the introduction of the definition:
>    #define _XOPEN_SOURCE 600
> the sprintf code is not working anymore.
> I'm attaching a patch that makes the saving of the session
> work again. It is not elegant code, but it can be used
> as a reference about what needs to be done.

Yikes - those are wrong.  We discovered several of these in the past - 
guess we missed a few.

Fixed by manually applying your diff.  PLEASE use /git format-patch/ in 
the future - makes my job a lot easier.

Thanks!

-jon

>
> That's all for the moment.
> Giacomo
>
>
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono

Re: [cdesktopenv-devel] [PATCH] Fix build under LLVM15

[Jon T. <jo...@ra...>]

On 2/16/23 08:50, Cy Schubert wrote:
> On Thu, 16 Feb 2023 14:30:41 +0000
> Chase<nic...@pr...>  wrote:
>
>> You must not directly edit any file under ksh93, instead, pull the newest point release from the source and merge it. Its a git subtree so I'm not quite sure how that works.
> I know how it works. We at FreeBSD use subtrees for vendor branches
> (contributed code). (We have ATM decided to use subtrees instead
> of submodules but that may change in the future.) Though, we sometimes
> apply our own patches to /usr/src/contrib which are eventually
> upstreamed, while other times we submit a patch and wait.
>
> I've updated the FreeBSD ksh ports with the same atomics patch. I plan
> on upstreaming that too. Just haven't gotten around to it yet.
>
> I'll resubmit the patch minus the ksh bit.
>

I think I will apply this patch as-is for now.  Chase has a point in 
that it causes conflicts the next time we want to resync with upstream 
ksh, but I have no idea how long it will take for:

- the patch to make it into ksh (https://github.com/ksh93/ksh/pull/601)
- CDE to resync with upstream

Plus this issue causes FTBFS

So, let's throw all caution to the wind and apply it for now.

Though I am suspicious of the ksh fix - it seems incongruous to check 
for defined(_aso_casptr), but then instead use _aso_cas64()...  So not 
sure if that will be considered correct from a ksh maintainer 
perspective.  Guess we will see :)


-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono

Re: [cdesktopenv-devel] [PATCH] fix MANDIR output from dtsearchpath

[Jon T. <jo...@ra...>]

On 2/6/23 22:50, Giacomo Comes wrote:
> On Sat, Feb 04, 2023 at 01:29:26PM -0700, Jon Trulson wrote:
>> On 1/31/23 23:21, Giacomo Comes wrote:
>>> The value of MANDIR from dtsearchpath is missing the CDE man directory.
>>> Restore it.
>>>
>> Hi, I've applied this, and the following patches:
>>
>> - missing dtopen_* links
>> - /usr/dt/bin is always needed
>> - fix DTKORNSHELL output for dtlp
>>
>> I did not apply the ksh manpage rename patch since there is already a fix in
>> master for this: Since we do not install ksh, we will no longer install the
>> manpage for it at all.
> I disagree. You do install ksh and it is called dtksh.
> The man page dtksh.1 only refers to the dt extensions.
> For options, operands, input files, etc, such man page points to the (k)sh.1
> man page. Since the version of ksh installed with the OS is different from
> the one used to build dtksh, the correct documantation of dtksh can be found
> only in cde's ksh man page. To avoid any conflict or confusion, my patch renames
> cde's ksh.1 as ksh-cde.1

That's an excellent point.  I've gone ahead and applied this.

--jon

> Giacomo
>   
>> However, in the future please use /git format-patch .../ to send patches to
>> the list, OR use SourceForge's MR mechanism to submit merge requests.
>>
>> See:https://sourceforge.net/p/cdesktopenv/wiki/Contributing%20to%20CDE/
>>
>> I generally ignore malformed submissions as I don't have the time to do the
>> work for you, but these seem reasonable and at some point I'd really like to
>> be able to allow CDE to be installed anywhere rather than a hardcoded
>> /usr/dt.  This is a big job to do correctly however.
>>
>> Thanks!
>>
>>
>>
>>> _______________________________________________
>>> cdesktopenv-devel mailing list
>>> cde...@li...
>>> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
>> -- 
>> Jon Trulson
>>
>>    "The less you know, the more you believe."
>>                             -- Bono
>
>> _______________________________________________
>> cdesktopenv-devel mailing list
>> cde...@li...
>> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono

Re: [cdesktopenv-devel] [PATCH] Fix build under LLVM15

[Cy S. <Cy....@cs...>]

On Thu, 16 Feb 2023 14:30:41 +0000
Chase <nic...@pr...> wrote:

> You must not directly edit any file under ksh93, instead, pull the newest point release from the source and merge it. Its a git subtree so I'm not quite sure how that works.

I know how it works. We at FreeBSD use subtrees for vendor branches
(contributed code). (We have ATM decided to use subtrees instead
of submodules but that may change in the future.) Though, we sometimes
apply our own patches to /usr/src/contrib which are eventually
upstreamed, while other times we submit a patch and wait.

I've updated the FreeBSD ksh ports with the same atomics patch. I plan
on upstreaming that too. Just haven't gotten around to it yet.

I'll resubmit the patch minus the ksh bit.

-- 
Cheers,
Cy Schubert <Cy....@cs...>
FreeBSD UNIX:  <cy...@Fr...>   Web:  https://FreeBSD.org
NTP:           <cy...@nw...>    Web:  https://nwtime.org

			e^(i*pi)+1=0

> 
> 
> 
> Thank you for your time,
> -Chase
> 
> Sent with Proton Mail secure email.
> 
> ------- Original Message -------
> On Wednesday, February 15th, 2023 at 12:19 PM, Cy Schubert <Cy....@cs...> wrote:
> 
> 
> > Fix many -Wint-conversion errors such as the example below, including
> > an aso atomics error.
> > 
> > connect.c:87:12: error: incompatible pointer to integer conversion
> > initializing 'LONG' (aka 'int') with an expression of type 'void '
> > [-Wint-conversion]
> > DB_ADDR mdba = NULL; / db address of current member record */
> > ^ ~~~~
> > ---
> > cde/lib/DtHelp/AccessCCDF.c | 2 ++
> > cde/lib/DtSearch/raima/connect.c | 4 +--
> > cde/programs/dtappbuilder/src/ab/pal_button.c | 30 ++++++++--------
> > cde/programs/dtappbuilder/src/ab/pal_choice.c | 22 ++++++------
> > .../dtappbuilder/src/ab/pal_combobox.c | 16 ++++-----
> > cde/programs/dtappbuilder/src/ab/pal_cpanel.c | 14 ++++----
> > .../dtappbuilder/src/ab/pal_custdlg.c | 14 ++++----
> > cde/programs/dtappbuilder/src/ab/pal_drawp.c | 16 ++++-----
> > .../dtappbuilder/src/ab/pal_fchooser.c | 6 ++--
> > cde/programs/dtappbuilder/src/ab/pal_group.c | 36 +++++++++----------
> > cde/programs/dtappbuilder/src/ab/pal_label.c | 14 ++++----
> > cde/programs/dtappbuilder/src/ab/pal_list.c | 24 ++++++-------
> > .../dtappbuilder/src/ab/pal_mainwin.c | 8 ++---
> > cde/programs/dtappbuilder/src/ab/pal_menu.c | 28 +++++++--------
> > .../dtappbuilder/src/ab/pal_menubar.c | 4 +--
> > cde/programs/dtappbuilder/src/ab/pal_scale.c | 24 ++++++-------
> > cde/programs/dtappbuilder/src/ab/pal_sep.c | 22 ++++++------
> > .../dtappbuilder/src/ab/pal_spinbox.c | 22 ++++++------
> > cde/programs/dtappbuilder/src/ab/pal_termp.c | 18 +++++-----
> > cde/programs/dtappbuilder/src/ab/pal_textf.c | 16 ++++-----
> > cde/programs/dtappbuilder/src/ab/pal_textp.c | 22 ++++++------
> > .../dtksh/ksh93/src/lib/libast/aso/aso.c | 2 +-
> > 22 files changed, 183 insertions(+), 181 deletions(-)
> > 
> > 
> > 
> > Cheers,
> > Cy Schubert Cy....@cs...
> > 
> > FreeBSD UNIX: cy...@Fr... Web: https://FreeBSD.org
> > 
> > NTP: cy...@nw... Web: https://nwtime.org
> > 
> > 
> > e^(i*pi)+1=0
> > _______________________________________________
> > cdesktopenv-devel mailing list
> > cde...@li...
> > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel  

Re: [cdesktopenv-devel] [PATCH] Fix build under LLVM15

[Chase <nic...@pr...>]

You must not directly edit any file under ksh93, instead, pull the newest point release from the source and merge it. Its a git subtree so I'm not quite sure how that works.



Thank you for your time,
-Chase

Sent with Proton Mail secure email.

------- Original Message -------
On Wednesday, February 15th, 2023 at 12:19 PM, Cy Schubert <Cy....@cs...> wrote:


> Fix many -Wint-conversion errors such as the example below, including
> an aso atomics error.
> 
> connect.c:87:12: error: incompatible pointer to integer conversion
> initializing 'LONG' (aka 'int') with an expression of type 'void '
> [-Wint-conversion]
> DB_ADDR mdba = NULL; / db address of current member record */
> ^ ~~~~
> ---
> cde/lib/DtHelp/AccessCCDF.c | 2 ++
> cde/lib/DtSearch/raima/connect.c | 4 +--
> cde/programs/dtappbuilder/src/ab/pal_button.c | 30 ++++++++--------
> cde/programs/dtappbuilder/src/ab/pal_choice.c | 22 ++++++------
> .../dtappbuilder/src/ab/pal_combobox.c | 16 ++++-----
> cde/programs/dtappbuilder/src/ab/pal_cpanel.c | 14 ++++----
> .../dtappbuilder/src/ab/pal_custdlg.c | 14 ++++----
> cde/programs/dtappbuilder/src/ab/pal_drawp.c | 16 ++++-----
> .../dtappbuilder/src/ab/pal_fchooser.c | 6 ++--
> cde/programs/dtappbuilder/src/ab/pal_group.c | 36 +++++++++----------
> cde/programs/dtappbuilder/src/ab/pal_label.c | 14 ++++----
> cde/programs/dtappbuilder/src/ab/pal_list.c | 24 ++++++-------
> .../dtappbuilder/src/ab/pal_mainwin.c | 8 ++---
> cde/programs/dtappbuilder/src/ab/pal_menu.c | 28 +++++++--------
> .../dtappbuilder/src/ab/pal_menubar.c | 4 +--
> cde/programs/dtappbuilder/src/ab/pal_scale.c | 24 ++++++-------
> cde/programs/dtappbuilder/src/ab/pal_sep.c | 22 ++++++------
> .../dtappbuilder/src/ab/pal_spinbox.c | 22 ++++++------
> cde/programs/dtappbuilder/src/ab/pal_termp.c | 18 +++++-----
> cde/programs/dtappbuilder/src/ab/pal_textf.c | 16 ++++-----
> cde/programs/dtappbuilder/src/ab/pal_textp.c | 22 ++++++------
> .../dtksh/ksh93/src/lib/libast/aso/aso.c | 2 +-
> 22 files changed, 183 insertions(+), 181 deletions(-)
> 
> 
> 
> Cheers,
> Cy Schubert Cy....@cs...
> 
> FreeBSD UNIX: cy...@Fr... Web: https://FreeBSD.org
> 
> NTP: cy...@nw... Web: https://nwtime.org
> 
> 
> e^(i*pi)+1=0
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

[cdesktopenv-devel] [PATCH] Fix build under LLVM15

[Cy S. <Cy....@cs...>]

Fix many -Wint-conversion errors such as the example below, including
an aso atomics error.

connect.c:87:12: error: incompatible pointer to integer conversion 
initializing 'LONG' (aka 'int') with an expression of type 'void *' 
[-Wint-conversion]
   DB_ADDR mdba = NULL;   /* db address of current member record */
           ^      ~~~~
---
 cde/lib/DtHelp/AccessCCDF.c                   |  2 ++
 cde/lib/DtSearch/raima/connect.c              |  4 +--
 cde/programs/dtappbuilder/src/ab/pal_button.c | 30 ++++++++--------
 cde/programs/dtappbuilder/src/ab/pal_choice.c | 22 ++++++------
 .../dtappbuilder/src/ab/pal_combobox.c        | 16 ++++-----
 cde/programs/dtappbuilder/src/ab/pal_cpanel.c | 14 ++++----
 .../dtappbuilder/src/ab/pal_custdlg.c         | 14 ++++----
 cde/programs/dtappbuilder/src/ab/pal_drawp.c  | 16 ++++-----
 .../dtappbuilder/src/ab/pal_fchooser.c        |  6 ++--
 cde/programs/dtappbuilder/src/ab/pal_group.c  | 36 +++++++++----------
 cde/programs/dtappbuilder/src/ab/pal_label.c  | 14 ++++----
 cde/programs/dtappbuilder/src/ab/pal_list.c   | 24 ++++++-------
 .../dtappbuilder/src/ab/pal_mainwin.c         |  8 ++---
 cde/programs/dtappbuilder/src/ab/pal_menu.c   | 28 +++++++--------
 .../dtappbuilder/src/ab/pal_menubar.c         |  4 +--
 cde/programs/dtappbuilder/src/ab/pal_scale.c  | 24 ++++++-------
 cde/programs/dtappbuilder/src/ab/pal_sep.c    | 22 ++++++------
 .../dtappbuilder/src/ab/pal_spinbox.c         | 22 ++++++------
 cde/programs/dtappbuilder/src/ab/pal_termp.c  | 18 +++++-----
 cde/programs/dtappbuilder/src/ab/pal_textf.c  | 16 ++++-----
 cde/programs/dtappbuilder/src/ab/pal_textp.c  | 22 ++++++------
 .../dtksh/ksh93/src/lib/libast/aso/aso.c      |  2 +-
 22 files changed, 183 insertions(+), 181 deletions(-)

Re: [cdesktopenv-devel] LLVM15 Compile Errors

[Marcin C. <sa...@sa...>]

On Tue, 14 Feb 2023, Cy Schubert wrote:

> Just a heads up. FreeBSD 14-CURRENT recently imported LLVM15. Since then a
> number of build (-Wint-conversion) errors have been exposed. I'll submit a
> pull request with fixes this or next week. This affects 2.5.1 and the
> latest HEAD.

Thanks, looks like ksh93 might need to have the support for C11 atomics added in
lib/libast/features/aso ...

Marcin

[cdesktopenv-devel] LLVM15 Compile Errors

[Cy S. <Cy....@cs...>]

Just a heads up. FreeBSD 14-CURRENT recently imported LLVM15. Since then a 
number of build (-Wint-conversion) errors have been exposed. I'll submit a 
pull request with fixes this or next week. This affects 2.5.1 and the 
latest HEAD.


-- 
Cheers,
Cy Schubert <Cy....@cs...>
FreeBSD UNIX:  <cy...@Fr...>   Web:  https://FreeBSD.org
NTP:           <cy...@nw...>    Web:  https://nwtime.org

			e^(i*pi)+1=0

[cdesktopenv-devel] Various issues with cde 2.5.1

[Giacomo C. <co...@na...>]

Hi,
I'm in the process of packaging CDE for opensuse.
While doing that I have found some issues and I have some doubts
that I would like to share with you.

1) CDE does not compile with gcc12. In many places it throws the error:
  error: control reaches end of non-void function [-Werror=return-type]
Attached there is a patch that makes CDE 2.5.1 compile with gcc12.
Please use such patch only as reference to see which functions
have problems. Do not consider the patch correct C code.
I just put some return statements here and there assuming
that whatever value was returned it would be ignored.
The purpose was only to have the build process proceed without errors
in order to find all the troubling functions.
While now urgent, this task needs to be done at some point.


2) If CDE is build with --prefix=/ust/dt (the default),
many binaries have rpath set. Since that is forbidden
by opensuse packaging rules, I'm forced to use the command
chrpath on such binaries.
configure has the option '--disable-rpath' but it does not seems to
work. Using such options or not does not make any difference.
Perhaps some Makefile.am needs adjust?


3) I have seen that in 2.5.1 only dtappgather is setuid.
In the past the list was bigger. Is that correct?
Is there any possibility that in the future no setuid
program will be necessary?


4) When I run dtbuilder, if I click on any widget in the main
window the program crashes showing the following error messages:

X Error of failed request:  BadAlloc (insufficient resources for operation)
  Major opcode of failed request:  53 (X_CreatePixmap)
  Serial number of failed request:  14181
  Current serial number in output stream:  14184


5) Since 2.5.0 if I start from a terminal some CDE programs
(dtterm, dtpad, dtinfo, etc.) the following warning appears:
  Warning: Missing charset in String to FontSet conversion
  Warning: Missing charset in String to FontSet conversion
That didn't happens in CDE up to 2.4.0


6) In the file contrib/desktopentry/cde.desktop
it would be a good idea to add the line:
  DesktopNames=CDE
In this way, after a login, the desktop manager will set the environment variables:
XDG_CURRENT_DESKTOP and XDG_SESSION_DESKTOP


7) In the file programs/types/pgadmin.dt the line:
     ICON          pgadmin
should be:
     ICON          pgadmin3


8) /usr/dt/bin/dterror.ds does not work properly in CDE 2.5.x
It is build using programs/dtfile/dterror.src as source,
but is should be using programs/types/error.ds.src as source.
See databases/CDE-RUN.src in CDE up to 2.4.0


9) the command: 
  ksh -c 'echo "\n"'
prints a new line as output. So did the command: 
  dtksh -c 'echo "\n"'
in CDE up to 2.3.2.
Since 2.4.0 instead the same dtksh command prints: \n
To restore the correct behavior ECHOPRINT=1 must be set
in programs/dtksh/ksh93/src/cmd/ksh93/SHOPT.sh


10) If, for example, I execure the action: ApplicationManager/Desktop_Tools/Environment Variables,
in the output window I see at the end:
------------
\n*** Select Close or Exit from the window menu to close this window ***
------------
instead of:
------------

*** Select Close or Exit from the window menu to close this window ***
------------
The problem seems to be that many dtactions use: sh -c '...; echo ...\n...'
in order to print a new line. Since, on linux, generally sh is bash, echo -e '\n'
is required to print the new line. On a system where sh is a different shell
(zsh, ksh, dash) echo will work as expected.
My workaround for linux is to replace: 'sh -c' with: 'ksh -c'
For that purpose I use the following command:
  sed -i 's@\([[:blank:]]\)\(sh -c\)@\1k\2@' programs/types/*.{dt,src}
I guess such change should work for any architecture.


11) the session is not saved correctly for dtterm, dtpad and dticon.
In CDE 2.5; If you open dtterm or dtpad and logout, on the next login
such windows are not restored.
In the files programs/dticon/utils.c, programs/dtpad/session.c and
programs/dtterm/DtTermMain.c there is code like this:
  sprintf(buf, "%s some further text", buf)
The C99 and POSIX.1-2001 standard specify that the result is undefined,
I think that since the introduction of the definition:
  #define _XOPEN_SOURCE 600
the sprintf code is not working anymore.
I'm attaching a patch that makes the saving of the session
work again. It is not elegant code, but it can be used
as a reference about what needs to be done.


That's all for the moment.
Giacomo

Re: [cdesktopenv-devel] [PATCH] fix MANDIR output from dtsearchpath

[Giacomo C. <co...@na...>]

On Sat, Feb 04, 2023 at 01:29:26PM -0700, Jon Trulson wrote:
> On 1/31/23 23:21, Giacomo Comes wrote:
> > The value of MANDIR from dtsearchpath is missing the CDE man directory.
> > Restore it.
> > 
> 
> Hi, I've applied this, and the following patches:
> 
> - missing dtopen_* links
> - /usr/dt/bin is always needed
> - fix DTKORNSHELL output for dtlp
> 
> I did not apply the ksh manpage rename patch since there is already a fix in
> master for this: Since we do not install ksh, we will no longer install the
> manpage for it at all.

I disagree. You do install ksh and it is called dtksh.
The man page dtksh.1 only refers to the dt extensions.
For options, operands, input files, etc, such man page points to the (k)sh.1
man page. Since the version of ksh installed with the OS is different from
the one used to build dtksh, the correct documantation of dtksh can be found
only in cde's ksh man page. To avoid any conflict or confusion, my patch renames
cde's ksh.1 as ksh-cde.1

Giacomo
 
> However, in the future please use /git format-patch .../ to send patches to
> the list, OR use SourceForge's MR mechanism to submit merge requests.
> 
> See: https://sourceforge.net/p/cdesktopenv/wiki/Contributing%20to%20CDE/
> 
> I generally ignore malformed submissions as I don't have the time to do the
> work for you, but these seem reasonable and at some point I'd really like to
> be able to allow CDE to be installed anywhere rather than a hardcoded
> /usr/dt.  This is a big job to do correctly however.
> 
> Thanks!
> 
> 
> 
> > 
> > _______________________________________________
> > cdesktopenv-devel mailing list
> > cde...@li...
> > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
> 
> -- 
> Jon Trulson
> 
>   "The less you know, the more you believe."
>                            -- Bono


> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Re: [cdesktopenv-devel] [PATCH] fix MANDIR output from dtsearchpath

[Jon T. <jo...@ra...>]

On 1/31/23 23:21, Giacomo Comes wrote:
> The value of MANDIR from dtsearchpath is missing the CDE man directory.
> Restore it.
>

Hi, I've applied this, and the following patches:

- missing dtopen_* links
- /usr/dt/bin is always needed
- fix DTKORNSHELL output for dtlp

I did not apply the ksh manpage rename patch since there is already a 
fix in master for this: Since we do not install ksh, we will no longer 
install the manpage for it at all.

However, in the future please use /git format-patch .../ to send patches 
to the list, OR use SourceForge's MR mechanism to submit merge requests.

See: https://sourceforge.net/p/cdesktopenv/wiki/Contributing%20to%20CDE/

I generally ignore malformed submissions as I don't have the time to do 
the work for you, but these seem reasonable and at some point I'd really 
like to be able to allow CDE to be installed anywhere rather than a 
hardcoded /usr/dt.  This is a big job to do correctly however.

Thanks!



>
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono