[cc65-git] [cc65/cc65] c81aaa: fix sp65 PCX reader: 1bpp monochrome path wrote pa...

[Bob A. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/cc65/cc65
  Commit: c81aaa05afb4bc72ed21993f3c9aafa1521f3b6d
      https://github.com/cc65/cc65/commit/c81aaa05afb4bc72ed21993f3c9aafa1521f3b6d
  Author: Stefan A. Haubenthal <po...@sd...>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M src/sp65/pcx.c

  Log Message:
  -----------
  fix sp65 PCX reader: 1bpp monochrome path wrote past bitmap allocation

ReadPlane() already expands packed bits to one byte per pixel for
case 1 (1bpp), but the loop in ReadPCXFile treated the buffer as
still-packed bits using a mask-and-shift pattern. The for-loop also
failed to increment X, causing an infinite loop that wrote past the
allocated bitmap and triggered SIGBUS.

Fix: use the same direct L[X] indexing as the 8bpp path, matching
ReadPlane's pre-expanded output.


  Commit: 7ff3dfdabf13a9022a1b6e86bd84b48f42b114fd
      https://github.com/cc65/cc65/commit/7ff3dfdabf13a9022a1b6e86bd84b48f42b114fd
  Author: Bob Andrews <mr...@us...>
  Date:   2026-05-10 (Sun, 10 May 2026)

  Changed paths:
    M src/sp65/pcx.c

  Log Message:
  -----------
  Merge pull request #2960 from polluks/status

Fix sp65 PCX reader: 1bpp monochrome path wrote past bitmap allocation


Compare: https://github.com/cc65/cc65/compare/48be9a55f32b...7ff3dfdabf13

To unsubscribe from these emails, change your notification settings at https://github.com/cc65/cc65/settings/notifications