[cc65-git] [cc65/cc65] c4698d: Use C89 semantics for integer conversions

[Jesse R. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/cc65/cc65
  Commit: c4698dfd07383e4ffa50d6c1fa5d158052b167a9
      https://github.com/cc65/cc65/commit/c4698dfd07383e4ffa50d6c1fa5d158052b167a9
  Author: Jesse Rosenstock <jm...@go...>
  Date:   2020-08-15 (Sat, 15 Aug 2020)

  Changed paths:
    M src/cc65/codegen.c
    M src/cc65/datatype.c
    M src/cc65/datatype.h
    M src/cc65/expr.c
    R test/todo/bug170.c
    A test/val/bug170.c

  Log Message:
  -----------
  Use C89 semantics for integer conversions

Previously, the following rules were used for binary operators:
* If one of the values is a long, the result is long.
* If one of the values is unsigned, the result is also unsigned.
* Otherwise the result is an int.

C89 specifies the "usual arithmetic conversions" as:
* The integral promotions are performed on both operands.
* Then the following rules are applied:
  * If either operand has type unsigned long int, the other operand is
    converted to unsigned long int.
  * Otherwise, if one operand has type long int and the other has type
    unsigned int, if a long int can represent all values of an unsigned int,
    the operand of type unsigned int is converted to long int; if a long int
    cannot represent all the values of an unsigned int, both operands are
    converted to unsigned long int.
  * Otherwise, if either operand has type long int, the other operand is
    converted to long int.
  * Otherwise, if either operand has type unsigned int, the other operand is
    converted to unsigned int.
  * Otherwise, both operands have type int.
https://port70.net/~nsz/c/c89/c89-draft.html#3.2.1.5

As one example, these rules give a different result for an operator
with one long operand and one unsigned int operand.  Previously,
the result type was unsigned long.  With C89 semantics, it is just long,
since long can represent all unsigned ints.

Integral promotions convert types shorter than int to int (or unsigned int).
Both char and unsigned char are promoted to int since int can represent
all unsigned chars.
https://port70.net/~nsz/c/c89/c89-draft.html#3.2.1.1

Rename promoteint to ArithmeticConvert, since this is more accurate.

Fixes #170