[Cayambe-development] FW: org.cayambe.dao.CategoryDAO

[James W. <ja...@fi...>]

Thanks for your help Chris!

I will look into some of this stuff when I get back to my office on =
Tuesday.  In the mean time, maybe someone else can offer some answers.  =
Thanks!

-James
We're gonna be big!


-----Original Message-----
From:	Christian Mouttet [mailto:cmo...@we...]
Sent:	Sun 5/26/2002 8:43 AM
To:	James Ward
Cc:	md...@wa...; jo...@wa...
Subject:	org.cayambe.dao.CategoryDAO
James,

I'm started to write JUnit code for the dao classes for automated=20
testing and to get familiar with existing code.

I found a lot of violations against basic code conventions :-( e.g. some =

method names, line length, etc. ...will fix them.

Is the save method already finished? I thinks it's not because the=20
INSERT statement in the case of id=3D=3D0 doesn't generate a new id. =
Instead=20
of that the DAO wants to save with id=3D=3D0 with the result of =
duplicate ids.

Is 'SaveProductToCategory()' and 'RemoveProductsFromCategory()' already=20
in use? I would expect this funcionality in ProductDAO instead of=20
CategoryDAO.

Why is there getAllCategories(CategoryVO selectedCategory) without using =

the selectedCategory in the code? What is the difference to the=20
listCategories()? BTW: For what is category.visible and product.visible=20
used? Do the columns mean: Visible on the web interface?

At last: I'll improve the build.xml. It always cleans up before=20
building. That's ineffective since ant can optimize the builing process=20
with compiling only the changed classes.

How do you think about that?

Have a nice day!

chris