Menu

#12 Makefile.am contains hard-coded path

0.7
closed-accepted
5
2002-02-04
2002-01-13
No

The src/Makefile.am file in the miniviewer contains hard-coded paths like this:

# set the include path found by configure
INCLUDES = $(all_includes) -I../../cal3d/src/cal3d

I extracted all the packages in one top-level directory, and these
path in this case should have been
../../cal3d-0.7/src

Since you package the miniviewer and the library in separately
(a wise move), I think the correct way would be to let
the autconf scripts to discover the header files.
My suggestion:
- add to configure.in
AC_CHECK_HEADER(cal3d.h)
configure would check for the header file. You would have to
set the extra include path
- in some global shell variable, or
- with the --with-extra-includes=DIR option.
This also requires that you process those options and add
them to CPPFLAGS *before* the AC_CHECK_HEADER macro executes,
doing sg like this:

CPPFLAGS="${CPPFLAGS} $USER_INCLUDES"

It's also a good idea to add some extra action on failure in
AC_CHECK_HEADER (extra message and/or quit), because the 'checking for cal3d.h... no' line
is very easy to overlook.

regards,
Adam

Discussion

  • Anonymous

    Anonymous - 2002-01-19
    • assigned_to: nobody --> beosil
     
  • Anonymous

    Anonymous - 2002-02-04
    • status: open --> closed-accepted
     
  • Anonymous

    Anonymous - 2002-02-04

    Logged In: YES
    user_id=74825

    The automake/autoconf setup has been completely revamped.

    The Cal3D libs and headers are now checked in the standard
    paths first (e.g. /usr/local/...) and if this fails they
    are searched in the vicinity, meaning in "../cal3d/...".
    This is done to make the lazy ones happy without force
    them to give extra flags to ./configure.

     

Log in to post a comment.