Re: [c3p0-users] human readable c3p0 bean names
Status: Beta
Brought to you by:
swaldman
From: Bryan V. <bv...@po...> - 2012-10-22 14:51:59
|
Not at all, thanks Tim. I'd really like to see this picked up as well. I've used c3p0 in a number of projects with great success over the years, and having good, historical telemetry on the db pool is a necessity when doing load testing analysis and optimization. This thing has saved my bacon a few times. ________________________________ From: Tim Ehlers [eh...@ya...] Sent: Monday, October 22, 2012 10:43 AM To: Bryan Varner; c3p...@li... Subject: Re: [c3p0-users] human readable c3p0 bean names Sorry i was in a rush, I'm supporting what you are doing in this patch. The current way c3p0 works breaks metric gathers like jmxtrans and graphite (with the naming that uses horrible things like | ). Writing a script to invoke a softReset is doable but painful the way things are now. Your patch would fix all of this. I thank you for the patch submission. Sorry if i was confusing. I really hope this is picked up into mainline. ________________________________ From: Bryan Varner <bv...@po...> To: Tim Ehlers <eh...@ya...>; "c3p...@li..." <c3p...@li...> Sent: Monday, October 22, 2012 9:24 AM Subject: RE: [c3p0-users] human readable c3p0 bean names Tim, Perhaps I'm not understanding you clearly, but it seems you think my patch will break the ability to gatherer metrics? I'm pretty sure my patch only adds an additional parameter to the ObjectName, which means any existing query for a C3P0 JMX bean (by type or identityToken) should continue to work. The difference is that now you can query by any combination of type, identityToken, or human-readable name. You should still be able to easily script soft resets. Regards, -Bryan ________________________________________ From: Tim Ehlers [eh...@ya...<mailto:eh...@ya...>] Sent: Friday, October 19, 2012 12:37 AM To: Bryan Varner; c3p...@li...<mailto:c3p...@li...> Subject: RE: [c3p0-users] human readable c3p0 bean names Human readable and you break metric gatherers like jmx trans. Not to mention how do you script doing soft resets for example it becomes very painful. Thanks, ill see if we can do the same. ------------------------------ On Thu, Oct 18, 2012 11:16 AM CDT Bryan Varner wrote: >Hi Tim, > >I submitted a pull request the other day on github to change the way pools are published in JMX. We've been running a version of 0.9.1 in production with my changes applies for nearly 18 months now. > >Having predictable, human-readable names is very valuable. We needed it to enable historically accurate instrumentation for telemetry systems. > >Here's my pull request -- I think it will work -- I no longer have a JDK 1.5 system to test the build on. > >https://github.com/swaldman/c3p0/pull/3 > >Regards, >- Bryan Varner > > > >________________________________ >From: Tim Ehlers [eh...@ya...<mailto:eh...@ya...>] >Sent: Thursday, October 18, 2012 10:38 AM >To: c3p...@li...<mailto:c3p...@li...> >Subject: [c3p0-users] human readable c3p0 bean names > >Is there anywhere i can set a property to show Human readable names? Ive searched as best i can but cannot find an answer. > >com.mchange.v2.c3p0 > > * type=C3P0Registry<http://hse-austin-1.qa1.orbitz.net:7000/ViewObjectRes//com.mchange.v2.c3p0%3Atype%3DC3P0Registry> > * type=PooledDataSource[30sakp8qvyuo491ux4ptz|11f13b08]<http://hse-austin-1.qa1.orbitz.net:7000/ViewObjectRes//com.mchange.v2.c3p0%3Atype%3DPooledDataSource%5B30sakp8qvyuo491ux4ptz%7C11f13b08%5D> > * type=PooledDataSource[30sakp8qvyuo491ux4ptz|6257828d]<http://hse-austin-1.qa1.orbitz.net:7000/ViewObjectRes//com.mchange.v2.c3p0%3Atype%3DPooledDataSource%5B30sakp8qvyuo491ux4ptz%7C6257828d%5D> > * type=PooledDataSource[30sakp8qvyuo491ux4ptz|7cd0570e]<http://hse-austin-1.qa1.orbitz.net:7000/ViewObjectRes//com.mchange.v2.c3p0%3Atype%3DPooledDataSource%5B30sakp8qvyuo491ux4ptz%7C7cd0570e%5D> |