[Buzztard-devel] [ buzztard-Bugs-2829960 ] inconsistent loop end convention

[SourceForge.net <no...@so...>]

Bugs item #2829960, was opened at 2009-07-31 00:33
Message generated for change (Tracker Item Submitted) made by berzerka
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=476037&aid=2829960&group_id=55124

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Patric Schmitz (berzerka)
Assigned to: Nobody/Anonymous (nobody)
Summary: inconsistent loop end convention

Initial Comment:
There are two places where the sequence loop_start and loop_end values are initialized with defaults in case they are -1. 

1. song.c:208, bt_song_update_play_seek_event:
  if(loop_start==-1) loop_start=0;
  if(loop_end==-1) loop_end=length-1;

2. sequence.c, bt_sequence_set_property:
...
  if(self->priv->loop_end==-1) {
          self->priv->loop_end=self->priv->length;
...
      if(self->priv->loop_end!=-1) {
        // make sure its more then loop-start
        if(self->priv->loop_start>-1) {
          if(self->priv->loop_end<self->priv->loop_start)
            self->priv->loop_end=self->priv->loop_start+1;
        }
        // make sure its less then or equal to length
        if(self->priv->length>0) {
          if(self->priv->loop_end>self->priv->length)
            self->priv->loop_end=self->priv->length;          
        }

I guess it should be length, not length-1 in song.c. 
could you verify this?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=476037&aid=2829960&group_id=55124