I cannot apply the patch. I'm getting an error caused by line 1086 in src/librt/primitives/annot/annot.c (struct txt_seg *tseg;). It looks like the patch wasn't made with the latest file version.
And BTW, 5 and 0 are integer constants. Their double counterparts are 5. and 0. ;)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
After a long time I got back to this:
In general, it looks good. There is only one thing, what you can improve: Add the two new parameters to rt_annot_describe() too.
BTW, I tried to change the deault values by converting to asc format and back to .g, but asc2g doesn't work with annotations.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
..
Could you please create a new patch based on the latest BRL-CAD repository trunk revision?
And, you should consider the new text parameters in ant_label_dimensions() too.
this is made on the new revision
Ups, the scale and the angle should be doubles, according to bn_vlist_2string().
this is fixed
I cannot apply the patch. I'm getting an error caused by line 1086 in src/librt/primitives/annot/annot.c (struct txt_seg *tseg;). It looks like the patch wasn't made with the latest file version.
And BTW, 5 and 0 are integer constants. Their double counterparts are 5. and 0. ;)
this one is better I fixed the issues
After a long time I got back to this:
In general, it looks good. There is only one thing, what you can improve: Add the two new parameters to rt_annot_describe() too.
BTW, I tried to change the deault values by converting to asc format and back to .g, but asc2g doesn't work with annotations.
describe function changes, I found a solution for the asc2g we can implement it after commiting this patch
sorry for the last patch it is totally wrong this one is the correct version
this is the correct patch
https://github.com/BRL-CAD/brlcad/commit/98d01c7b65f959ee2559c4b2b8b3892bb5ab83d2