#530 the position adjustment of the annotations

[ali haydar]

the default position of the annotation in the previous primitive was bottom left and the other eight choices of position flags weren't implemented this patch solves the problem

[Daniel Roßberg]

The patch seems to work. However, I've for sure some comments:

• Why don't you use your bn_vlist_bbox() to get the label's dimensions?
• bn_vlist_2string() is called twice. Isn't it possible to call ant_pos_adjs() and ant_label_dimensions() with the vlist instead of struct txt_seg*?

[ali haydar]

-I think we can't use bn_vlist_bbox() because it considers the annotation as one point that was the goal of changing bn_vlist_bbox()

• the vlist contains three unnecessary points which are the (0,0,0) which make us can draw the leader line to the annotated point and tow points of the leader line
  -I will check why bn_vlist_2string() is called twic

[ali haydar]

I fixed the indents in this one hope it is better

[Daniel Roßberg]

Better, but hopefully not final ;)
The point with bn_vlist_bbox() was the display mode flag. But, bn_vlist_2string() doesn't set this flag. I.e., it could work. A test could show it.

[ali haydar]

okay in this way I think we can use bn_vlist_bbox() I will do it and send the patch

[ali haydar]

this one using bn_vlist_bbox() I tested it for all cases like the last time

[ali haydar]

sorry that one will not build on gcc because I forget the unused variables this one will work

[ali haydar]

I used bmin here I think it is better but ref_pt has to be passed to the function.

[Daniel Roßberg]

accepted with revision 73675

[ali haydar]

this is better one

[Daniel Roßberg]

Well, this ticket was already closed. Your patch 9 was committed to the repository and Sean made 9 additional fixes there. Look at the annot.c subversion history.

You should work on https://sourceforge.net/p/brlcad/patches/531/ now.