Menu

#491 Minor fixes to the patch #488

Unstable
closed-accepted
5
2018-06-03
2018-05-26
Sharan
No

This is to correct some mistakes made in the patch : https://sourceforge.net/p/brlcad/patches/488/
All changes were made according to last comment by Daniel on the patch:
1) In include/analyze.h:

  • newline at line 128
  • name the parameters in analyze_overlaps_callback, such that the user hasn't to guess what they mean

2) In src/libanalyze/overlaps/analyze_overlaps.c:

  • remove spaces in line 326

3) In src/libtclcad/tclcad_obj.c:

  • use a tab

4) Test with Archer

  • added an entry in ged.tcl for it to work with archer and it appears to be working fine.
1 Attachments

Discussion

  • Daniel Roßberg

    Daniel Roßberg - 2018-05-27
    • Parameter names as "pp" or "hp" aren't very selfexplanatory.
    • "options" at line 6234 in src/tclscripts/lib/Ged.tcl need to be set in squared brackets. They are optional.
     
  • Sharan

    Sharan - 2018-06-03

    Following changes:
    1) Getting objects from view and getting view info if objects are not mentioned.
    2) Added plotting overlay function to check_overlaps
    3) Fixed a bug with overlaps having the same name for reg1 and reg2.
    4) Not passing hp and ap to overlapHandler instead passing rayp for plotting.
    5) Added debug flag to print debug information.
    6) Accordingly changes for archer related files.

     

    Last edit: Sharan 2018-06-03
  • Daniel Roßberg

    Daniel Roßberg - 2018-06-03
    • status: open --> closed-accepted
    • assigned_to: Daniel Roßberg
    • Group: Incomplete --> Unstable
     
  • Daniel Roßberg

    Daniel Roßberg - 2018-06-03

    src/libged/check_overlaps.c:

    • file name (in the first line)
    • bn/plot3.h really necessary?
    • double new-line in lines 66/67
     

Log in to post a comment.

MongoDB Logo MongoDB