First, you have to follow the rules described in the HACKING file, especially the CODING STYLE & STANDARDS section there. Please, adjust your code such that it fulfils these rules.
In addition, the centroid is always on the x=y=0 line? That's hard to believe.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Will go through the file and rectify the errors. Apologies for that.
The centroid will always lie at some point on the height vector and I is assumed that the vertex of the asymptotes is (0,0) (my bad!) , but you are right, the centroid will change as the vertex changes from (0,0). Will rectify it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This looks better, but I've still some remarks:
- BRL-CAD requires a mixture of spaces and tabs for indentation, see "1) Indentation whitespace" in HACKING.
- Trailing spaces are bad too. There is a line with only white spaces in your patch.
- Your centroid lies somewhere along ehy_Au (unit vector along semi-major axis). I would have expected it more near ehy_H (height vector). Besides, you use ehy_r1 but not ehy_r2. Do you have a reference in the literature for your formula?
- You could consider to use vmath.h macros for your vector operations, e.g. VADD2, VSCALE, or VADD2SCALE.
Last edit: Daniel Roßberg 2017-03-17
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Status: open Group: Incomplete Created: Wed Mar 08, 2017 09:27 AM UTC by Shubham Rathore Last Updated: Tue Apr 04, 2017 09:46 PM UTC Owner: Sean Morrison Attachments:
Duh ;)
You should definitily mention it in the source, similar to rt_ehy_surf_area(). Souces used should be referenced (in the source code or development log for example).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Duh ;)
You should definitily mention it in the source, similar to
rt_ehy_surf_area(). Souces used should be referenced (in the source code or
development log for example).
Status: open Group: Incomplete Created: Wed Mar 08, 2017 09:27 AM UTC by Shubham Rathore Last Updated: Wed Apr 05, 2017 02:43 PM UTC Owner: Sean Morrison Attachments:
revised: the previous patch had some issues
revision: there was an unexpected build error, rectified
First, you have to follow the rules described in the HACKING file, especially the CODING STYLE & STANDARDS section there. Please, adjust your code such that it fulfils these rules.
In addition, the centroid is always on the x=y=0 line? That's hard to believe.
Will go through the file and rectify the errors. Apologies for that.
The centroid will always lie at some point on the height vector and I is assumed that the vertex of the asymptotes is (0,0) (my bad!) , but you are right, the centroid will change as the vertex changes from (0,0). Will rectify it.
UPDATED
This looks better, but I've still some remarks:
- BRL-CAD requires a mixture of spaces and tabs for indentation, see "1) Indentation whitespace" in HACKING.
- Trailing spaces are bad too. There is a line with only white spaces in your patch.
- Your centroid lies somewhere along ehy_Au (unit vector along semi-major axis). I would have expected it more near ehy_H (height vector). Besides, you use ehy_r1 but not ehy_r2. Do you have a reference in the literature for your formula?
- You could consider to use vmath.h macros for your vector operations, e.g. VADD2, VSCALE, or VADD2SCALE.
Last edit: Daniel Roßberg 2017-03-17
Indented according to HACKING
used indent.sh and ws.sh
Centroid function updated
OK, then one question is still open: You use ehy_r1 but not ehy_r2, do you have a reference in the literature for your formula?
https://docs.google.com/file/d/0BydeQ6BPlVejRWt6NlJLVDl0d28/edit Can be
referred !
On Wed, Apr 5, 2017 at 8:13 PM, "Daniel Roßberg" d_rossberg@users.sf.net
wrote:
Related
Patches:
#457Last edit: Shubham Rathore 2017-04-07
Duh ;)
You should definitily mention it in the source, similar to rt_ehy_surf_area(). Souces used should be referenced (in the source code or development log for example).
Oh! I'll mention it for sure.
On Thu, Apr 6, 2017 at 9:07 PM, "Daniel Roßberg" d_rossberg@users.sf.net
wrote:
Reference added
I'm not a native English speaker but could it be that "referenced from" means exactly the opposite from what you mean?
You may be right, hence the update
UPDATED
Patch applied with revision 69630.