Henry, this looks good but the file you submitted cannot be applied to the BRL-CAD sources... You manually ran diff on files that you changed the name on, so the patch file cannot be automatically applied. Basically, we'd have to manually repeat all of the edits you just made ... which would be an incredible waste of time, particularly for fixing typos.
The point of a patch file is something that can be directly applied to a fresh checkout (usually via patch -p0 < yourpatchfile). See http://brlcad.org/wiki/Patches
Also, are you still working on a logic patch too?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I am now submitting a patch for just one file from the group to see whether I've done it right this time (or at least gotten closer). What do you think?
This is my first patch. It tackles the issue found at this address:
http://www.google-melange.com/gci/task/view/google/gci2013/4932878790033408
Attached is additional information about the documents in the patch.
Henry, this looks good but the file you submitted cannot be applied to the BRL-CAD sources... You manually ran diff on files that you changed the name on, so the patch file cannot be automatically applied. Basically, we'd have to manually repeat all of the edits you just made ... which would be an incredible waste of time, particularly for fixing typos.
The point of a patch file is something that can be directly applied to a fresh checkout (usually via patch -p0 < yourpatchfile). See http://brlcad.org/wiki/Patches
Also, are you still working on a logic patch too?
I am now submitting a patch for just one file from the group to see whether I've done it right this time (or at least gotten closer). What do you think?
Diff:
I am happy to contribute.