There are three patch files in this patch submission. Are they all supposed to be applied or just the last one? Please review your other patches and if any have multiple files, you need to say whether we're expected to apply all or just the last one.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
ICV library in its original implementation, has a function definition called icv_load. icv_load is currently unimplemented. This patch implements icv_load functionality for pix format.
This patch was a part of patch which was submitted during GSOC application period by me.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This patch introduces trailing whitespace, please verify that the file satisfies HACKING.
The load_pix function is placed in the public function section as denoted by comments, it should be in the private function section.
The going naming format for that file is <format>_<operation> (like pix_save), new functiosn should follow existing convention (so pix_load)
If you allocate the bif first, then you can bu_calloc() the bif->data instead of carrying a local 'data' variable, as well as just use the bif->fd without the fd local.
Allocation of bif and data are not tested, this could cause a crash if bu_malloc() fails.</operation></format>
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hii Erik,
Resurrected the new patch (see att. pixload_Rev2.patch) removed trailing spaces. changed function name removed extra variables. bu_malloc issue resolved on IRC.
This has for bw format.
Last edit: zero_level 2013-07-02
This has for png format.
Last edit: zero_level 2013-07-02
There are three patch files in this patch submission. Are they all supposed to be applied or just the last one? Please review your other patches and if any have multiple files, you need to say whether we're expected to apply all or just the last one.
Sean,
I have removed the other two patch files to avoid confusions.
This patch file pixload.patch has a load functionality for pix format. This applies cleanly.
Last edit: zero_level 2013-07-02
A brief discription about this patch.
ICV library in its original implementation, has a function definition called icv_load. icv_load is currently unimplemented. This patch implements icv_load functionality for pix format.
This patch was a part of patch which was submitted during GSOC application period by me.
This patch introduces trailing whitespace, please verify that the file satisfies HACKING.
The load_pix function is placed in the public function section as denoted by comments, it should be in the private function section.
The going naming format for that file is <format>_<operation> (like pix_save), new functiosn should follow existing convention (so pix_load)
If you allocate the bif first, then you can bu_calloc() the bif->data instead of carrying a local 'data' variable, as well as just use the bif->fd without the fd local.
Allocation of bif and data are not tested, this could cause a crash if bu_malloc() fails.</operation></format>
Hii Erik,
Resurrected the new patch (see att. pixload_Rev2.patch)
removed trailing spaces.
changed function name
removed extra variables.
bu_malloc issue resolved on IRC.
applied as r55930, with indentation fixes in 55931.