Thread: [brlcad-devel] Floating Point Comparisons
Open Source Solid Modeling CAD
Brought to you by:
brlcad
From: Tom B. <tom...@gm...> - 2011-02-15 18:03:39
|
Sean, thanks for correcting my FP comparison "fixes." Note that I did see the ZERO and EQUAL macros in vmath.h and considered using them but the comment for both there says: "Use not recommended due to compilation-variant tolerance." Perhaps the notes should be removed or changed to: "Use is recommended when FP comparisons are absolutely necessary." Also, how about adding a blurb on this topic in HACKING? Perhaps something like: <quote> When FP comparisons are absolutely necessary, use the ZERO and EQUAL macros (defined in vmath.h which is included in bu.h). Examples of use: * instead of "foo == 2.0" use "EQUAL(foo,2.0)" * instead of "foo > 0.0" use "foo > ZERO" </quote> One more point. Do you mean to keep ZEROTOL and "foo > ZEROTOL" in firpass.c (which seems to go against your other changes)? Best regards, -Tom Thomas M. Browder, Jr. Niceville, Florida USA |