Menu

#2 "make install" fails

open
nobody
None
5
2007-11-02
2007-11-02
MaxiPunkt
No

Hello there,

I just tried out Brikx 0.4.0b.
Unfortunately it only runs when copying the data-files manually, as described in your README.

I run Mandriva-Linux and tried to make a system-wide setup. Mandriva's conventions are:
* game-BIN's should go to: /usr/games/<name>
* games-data should go to: /usr/share/games/<name>

If I do a
./configure --bindir=/usr/games --datadir=/usr/share/games

and copy all files in the right place after doing "make", brikx isn't able to find it's data!

Could you please fix your Makefile?
Otherwise a system-wide installation and therefore building a package for the distro is impossible.

Discussion

  • glezmen

    glezmen - 2007-12-21

    Logged In: YES
    user_id=1001791
    Originator: NO

    Yes, I know the problem, but to tell the truth, I'm not yet really familier with automake and makefiles, I should spend some time to do it
    I plan to fix that problem too, but I have several other (paid) projects, so I have very little time for Brikx :(

     
  • MaxiPunkt

    MaxiPunkt - 2008-02-16

    Logged In: YES
    user_id=1336936
    Originator: YES

    Unfortunately this bug is still present in new released version 0.4.1

    * make install doesn't work properly
    * The executable insists to have the game-data in the same folder as the executable
    ./configure --datadir=<my folder> doesn't help

    And you invented a new bug:
    The permissions of the empty folder "src/data/high" is wrong. I had to do an:
    chmod +x src/data/high

    Please fix your ./configure- and makefile

     
  • glezmen

    glezmen - 2008-02-16

    Logged In: YES
    user_id=1001791
    Originator: NO

    yes, make install doesn't work correctly.
    for now, a simple installation script named INSTALL is available in brikx directory, if you run it as root (or with sudo) it will install brikx, copy the data directory and creates a startup script
    in the next releases make install will be fixed
    thank you for your report!

     
  • MaxiPunkt

    MaxiPunkt - 2008-02-16

    Logged In: YES
    user_id=1336936
    Originator: YES

    You missed what I was trying to say:

    Beside this "make install"-issue your program wants to have it's data in the same folder as the executable.
    This is o.k. as long as you do a local install in your home-directory.

    In all distros I know the executable has to be separated from its data - this is what
    ./configure --bindir=... --datadir=... is for. Some examples:

    Mandriva-Linux (for games):
    * bindir = /usr/games
    * datadir = /usr/share/games

    Debian:
    * bindir = /usr/local/bin
    * datadir = /usr/local/share/games

    I've looked up your code a little bit, the main problem is that you have "hardcoded" the datadir, i.e. inside file src/brikx.h:
    #define DIR_DATA "data/"

    This should not be a fix directory, but a variable respecting what was given with:
    ./configure --datadir=...

    Please fix the hardcoded datadir, I really like the idea of Brikx, and I would like to share the game with others by building an RPM for Mandriva.

     
  • glezmen

    glezmen - 2008-02-16

    Logged In: YES
    user_id=1001791
    Originator: NO

    I understand your problem, and you're absolutely right
    it will be fixed

    thanks

    bokorn

     

Log in to post a comment.