Menu

#3 Several Comment/Uncomment issues

1.0.2
Fixed
nobody
None
Medium
Defect
2013-09-13
2013-09-10
Anonymous
No

Originally created by: l.on... (code.google.com)@gmail.com
Originally owned by: tortoisesvn

* If the language of the current file is not known, the comment button does nothing and keeps the selection (nice), but the uncomment button loses the selection (not perfect)

* The Ctrl-K,C or Ctrl-K,U hotkeys insert a "c" or "u" in place of the selected text (not nice)

The following issues were with an XML file, haven't tried another file type:
* Comment works (as often as I like), so I can comment comments inside comments (OK, but is it good? see below)

* Uncomment doesn't do anything.

* Comment/Uncomment loses the line selection. I think the selection should persist, so that comment/uncomment can be toggled.

* Comment/Uncomment could become a single button. Either something is not commented, so comment it out or vice versa. Does it make sense to comment a comment inside a comment?

Discussion

  • Anonymous

    Anonymous - 2013-09-10

    Originally posted by: tortoisesvn

    I'll have a look at this, but I can not reproduce the issue where a "c" or an "u" is inserted in place of the selected text.

     
  • Anonymous

    Anonymous - 2013-09-12

    Originally posted by: simon.to... (code.google.com)@gmail.com

    In C files I can select multiple lines and comment. If I then select the same lines, uncomment does nothing. If I put the cursor somewhere in a commented line then uncomment works for that line alone.

    Similar to CSS files I find that in PHP files I can comment a single line or multiple lines but I cannot uncomment them. If the cursor is somewhere in the middle of the comment with nothing selected it doesn't work. If the lines(s) are selected it doesn't work. Nothing special about the file, example attached.

     
  • Anonymous

    Anonymous - 2013-09-13

    Originally posted by: tortoisesvn

    (No comment was entered for this change.)

    Labels: Milestone-1.0.2
    Owner: tortoisesvn
    Status: Started

     
  • Anonymous

    Anonymous - 2013-09-13

    Originally posted by: tortoisesvn

    This issue was closed by revision [r369].

    Status: Fixed

     
MongoDB Logo MongoDB