[Bodington-developers] HTTP size header on downloaded files

[Matthew B. <mat...@ou...>]

We had reports of downloaded MP3s not playing correctly with quicktime 
under firefox. Looking into this it seemed that the Content-length was 
not being set on the downloaded file which mean that the quicktime 
plugin was only playing the first few seconds of the file.

The problem was that the compiler was converting the constant 0x80000000 
to Integer.MIN_VALUE on the line:

long size = uf.getSize();
if (size > 0L && size < 0x80000000)
   res.setContentLength((int) size);

which means that the header was never being set.

I've converted this to:

if (size > 0L && size <= (long)Integer.MAX_VALUE)

which means content length headers should get set for most uploaded 
files. The fix is in Bodington CVS HEAD.

-- 
  -- Matthew Buckett, VLE Developer
  -- Learning Technologies Group, Oxford University Computing Services
  -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/