From: Jon M. <jo...@te...> - 2006-07-19 13:01:36
|
Alistair Young wrote: >> If credentials are set then valid is set false ... set valid=true >> when the authentication failed >> > this kind of weirdness! > Alistair[weird] = Jon[Ingenious] ;-) > >> eventually I'll generalise it and commit >> back to the release version >> > can you not generalise it from the start? Two reasons not to - 1) It has to be deployed on Saturday. 2) It initially has some hard wired extras, i.e. whether the user is a student or staff is found by looking at the length of an attribute in the LDAP record and because I'm not 100% confident about the user names currently in the Bodington database always corresponding to the user names in the LDAP extra checks are made - payroll number and student number must match. So, before it replaces the current authenticator it needs these kinds of things separated out and I don't have time to do it now. Another problem - the nice constructor with the timeout option doesn't do what I thought it would! The number is used to set the socket data reading timeout which is not the same as the socket connection timeout. However, I think I found another way to make it work using a custom socket factory. Jon |