[Bodington-developers] BuildingSessionManagerImpl.getSession(Class)

[Matthew B. <mat...@ou...>]

It seems that lots of bits of code call this method asking for a 
NavigationSession and then throw the session away. Almost all the calls 
have access to a Request which also contains the NavigationSession. 
Should we just switch to always getting the NavigationSession out of the 
request?

getSession(Class) - org.bodington.server.BuildingSessionManagerImpl
	bytesuploaded(Request, PrintWriter) - 
org.bodington.servlet.facilities.Facility
	fileindex(Request, PrintWriter, String, boolean, boolean, int) - 
org.bodington.servlet.facilities.Facility
	fileinfo(Request, PrintWriter) - org.bodington.servlet.facilities.Facility
	fileisdeleted(Request) - org.bodington.servlet.facilities.Facility
	fileparagraph(Request, PrintWriter, String, boolean, String, String) - 
org.bodington.logbook.servlet.LogBookFacility
	filesContain(Request, PrintWriter, String, String) - 
org.bodington.logbook.servlet.LogBookFacility
	getServerNavigationSession() - org.bodington.servlet.HttpSession
	getSession(PrimaryKey, String, String) - 
org.bodington.server.BuildingSessionManagerImpl
	getStartPage(Request) - 
org.bodington.servlet.facilities.MediaDocumentFacility
	homeContainer(Request, PrintWriter) - 
org.bodington.servlet.facilities.Facility
	insert(Request, PrintWriter, String, String) - 
org.bodington.servlet.facilities.DocumentFacility
	metadatasearch(Request, PrintWriter) - 
org.bodington.servlet.facilities.Facility
	rawfileindex(Request, PrintWriter) - 
org.bodington.servlet.facilities.Facility

-- 
  -- Matthew Buckett, VLE Developer
  -- Learning Technologies Group, Oxford University Computing Services
  -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/