Re: [Bodington-developers] i18n - not finished yet!

[Alistair Y. <ali...@sm...>]

can someone get Peter commit access?

Alistair

On 20 Jul 2005, at 11:07, Brian Peter Clark wrote:

> I'm sorry about this, but it is a result of not knowing how things in
> Bods work.
>
> I saw a string literal that had semantic content: hidden to me,
> cach=E9 to a French person.
>
> If Alistair might send me one good file for the paths thing that he
> mentioned, I can sort things out. A couple of global edits..
>
> I sent the stuff to Alistair because I do not have the power or
> knowledge to commit anything (apart from these mistakes).
>
> Regards,
>
> Brian
>
>
>> Looking at the stuff that was checked in yesterday at about 19/07/05
>> 16:47 with the comment 'Localised'. (My vague understanding is =20
>> that this
>> is maybe stuff Leeds did, but Alistair checked in on their behalf, =20=

>> which
>> is why I'm sending this to the list, rather than an individual) is =20=

>> duff.
>> The problem is that certain calls to Facility which represent method
>> arguments (rather than user-displayed text) have been localised.
>>
>> A good example is the following (original):
>>
>> <call>
>> <target method=3D"insert"><variable name=3D"facility"/></target>
>> <parameters>
>>     <variable name=3D"request"/>
>>     <variable name=3D"writer"/>
>>     <literal type=3D"String">stylesheet</literal>
>>     <literal type=3D"String"></literal>
>> </parameters>
>> </call>
>>
>> This is basically facility.insert(request, writer, "stylesheet", =20
>> ""). It
>> should not be changed to the following:
>>
>> <call>
>> <target method=3D"insert"><variable name=3D"facility"/></target>
>> <parameters>
>>     <variable name=3D"request"/>
>>     <variable name=3D"writer"/>
>>     <literal type=3D"String"><localise =
d=3D"page.stylesheet"/></literal>
>>     <literal type=3D"String"></literal>
>> </parameters>
>> </call>
>>
>> This will work as expected for English. When you change the =20
>> language to
>> French, the insert() method will have no idea of what to insert when
>> called with the argument "le sheet de style".
>>
>> The files that are affected are the following:
>>
>> tomcatadd/webapps/bodington/templates/style_default/building/=20
>> main.html
>> tomcatadd/webapps/bodington/templates/style_default/directory/=20
>> consentconfirm.html
>> tomcatadd/webapps/bodington/templates/style_default/directory/=20
>> consentform.html
>> tomcatadd/webapps/bodington/templates/style_default/floor/main.html
>> tomcatadd/webapps/bodington/templates/style_default/mediadocument/=20
>> menu.html
>> tomcatadd/webapps/bodington/templates/style_default/password/=20
>> x509check.html
>> tomcatadd/webapps/bodington/templates/style_default/room/main.html
>> tomcatadd/webapps/bodington/templates/style_default/site/main.html
>> tomcatadd/webapps/bodington/templates/style_default/suite/main.html
>>
>> Prehaps if this was someone from Leeds, they can check this in to =20
>> CVS as
>> themselves and then we all know who to pat on the back when =20
>> they've got
>> them right ;-).
>>
>>
>> --
>> + - - - - - - - - - - - - - - - - - - - - - - - - - - - +
>> | Alexis O'Connor, VLE Developer (http://bodington.org) |
>> | OUCS, 13 Banbury Road, Oxford, OX2 6NN, UK.           |
>> | Tel. +44 (0)1865 283661                               |
>> + - - - - - - - - - - - - - - - - - - - - - - - - - - - +
>>
>>
>> -------------------------------------------------------
>> SF.Net email is sponsored by: Discover Easy Linux Migration =20
>> Strategies
>> from IBM. Find simple to follow Roadmaps, straightforward articles,
>> informative Webcasts and more! Get everything you need to get up to
>> speed, fast. http://ads.osdn.com/?ad_id=3D7477&alloc_id=3D16492&op=3Dcl=
ick
>> _______________________________________________
>> Bodington-developers mailing list
>> Bod...@li...
>> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>>
>>
>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&op=3Dclick
> _______________________________________________
> Bodington-developers mailing list
> Bod...@li...
> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>