Re: [Bodington-developers] i18n - not finished yet!

[Alistair Y. <ali...@sm...>]

Well spotted Alexis me o'l mate ;) I fell into this trap too but  
manged to crawl out before it was too late. I have an orchestra and  
fireworks show ready in the wings, awaiting the day we bin those  
templates for good :)

Peter - what do you want to do? can you check them out, rejig and  
check them back in? Don't use your local copy as they are in "pre- 
Tatham" format ;)

Alistair


On 20 Jul 2005, at 10:35, Alexis O'Connor wrote:

> Looking at the stuff that was checked in yesterday at about  
> 19/07/05 16:47 with the comment 'Localised'. (My vague  
> understanding is that this is maybe stuff Leeds did, but Alistair  
> checked in on their behalf, which is why I'm sending this to the  
> list, rather than an individual) is duff. The problem is that  
> certain calls to Facility which represent method arguments (rather  
> than user-displayed text) have been localised.
>
> A good example is the following (original):
>
> <call>
> <target method="insert"><variable name="facility"/></target>
> <parameters>
>     <variable name="request"/>
>     <variable name="writer"/>
>     <literal type="String">stylesheet</literal>
>     <literal type="String"></literal>
> </parameters>
> </call>
>
> This is basically facility.insert(request, writer, "stylesheet",  
> ""). It should not be changed to the following:
>
> <call>
> <target method="insert"><variable name="facility"/></target>
> <parameters>
>     <variable name="request"/>
>     <variable name="writer"/>
>     <literal type="String"><localise d="page.stylesheet"/></literal>
>     <literal type="String"></literal>
> </parameters>
> </call>
>
> This will work as expected for English. When you change the  
> language to French, the insert() method will have no idea of what  
> to insert when called with the argument "le sheet de style".
>
> The files that are affected are the following:
>
> tomcatadd/webapps/bodington/templates/style_default/building/main.html
> tomcatadd/webapps/bodington/templates/style_default/directory/ 
> consentconfirm.html
> tomcatadd/webapps/bodington/templates/style_default/directory/ 
> consentform.html
> tomcatadd/webapps/bodington/templates/style_default/floor/main.html
> tomcatadd/webapps/bodington/templates/style_default/mediadocument/ 
> menu.html
> tomcatadd/webapps/bodington/templates/style_default/password/ 
> x509check.html
> tomcatadd/webapps/bodington/templates/style_default/room/main.html
> tomcatadd/webapps/bodington/templates/style_default/site/main.html
> tomcatadd/webapps/bodington/templates/style_default/suite/main.html
>
> Prehaps if this was someone from Leeds, they can check this in to  
> CVS as themselves and then we all know who to pat on the back when  
> they've got them right ;-).
>
>
> -- 
> + - - - - - - - - - - - - - - - - - - - - - - - - - - - +
> | Alexis O'Connor, VLE Developer (http://bodington.org) |
> | OUCS, 13 Banbury Road, Oxford, OX2 6NN, UK.           |
> | Tel. +44 (0)1865 283661                               |
> + - - - - - - - - - - - - - - - - - - - - - - - - - - - +
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
> _______________________________________________
> Bodington-developers mailing list
> Bod...@li...
> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>