Re: [Bodington-developers] i18n res updated

[Alistair Y. <ali...@sm...>]

I don't follow now. Is this not overkill? The problem was the ant  
task not setting the language. Changing the format of Facility calls  
is not a good idea so near a release, is it?

All that needs done is to update the ant task to set the language  
from the build.properties. No other patches are required.

You spotted an enhancement for dynamically localised Facility calls  
but it's not required for 2.6, unless you're confident it works in  
all templates. It would also mean we could bin the language  
propagation from Template to XmlTemplate.

Can we just put the enhancement patches aside for now, update the ant  
task and see if template compilation works? If so, we can then  
proceed with any efficiency enhancements but I'm not happy about  
doing it so near the release.

Alistair

On 14 Jul 2005, at 11:18, Matthew Buckett wrote:

> Alistair Young wrote:
>
>> nice one! that'll do. My only concern was it caused NPE with  
>> style_0/ recycler/main.html.
>>
>
> Was that a NPE at compile or runtime?
>
> > That's nothing to do with the template  compilation
>
>> problem. It's a nice enhancement for dynamic localisation  though.  
>> Before you commit, can you make sure you're not seeing any  NPE  
>> with non localised templates?
>>
>
> Ok. I'll also remove your for localisation from getCharacterData().  
> One thing to note is I change the syntax for localised facility  
> calls from:
>
> <call>
>   <target method="variable"><variable name="facility"/></target>
>   <parameters>
>     <variable name="request"/>
>     <variable name="writer"/>
>     <literal type="String">
>       <localise id="page.title.text"/>
>     </literal>
>   </parameters>
> </call>
>
> to:
>
> <call>
>   <target method="variable"><variable name="facility"/></target>
>   <parameters>
>     <variable name="request"/>
>     <variable name="writer"/>
>     <localise id="page.title.text"/>
>   </parameters>
> </call>
>
> But my orginal patch include fixing the templates that were affected.
>
> -- 
> +--Matthew Buckett-----------------------------------------+
> | VLE Developer, Learning Technologies Group               |
> | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/       |
> +------------Computing Services, University of Oxford------+
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the 'Do More With Dual!' webinar  
> happening
> July 14 at 8am PDT/11am EDT. We invite you to explore the latest in  
> dual
> core and dual graphics technology at this free one hour event  
> hosted by HP, AMD, and NVIDIA.  To register visit http://www.hp.com/ 
> go/dualwebinar
> _______________________________________________
> Bodington-developers mailing list
> Bod...@li...
> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>